Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix handling of bytes outside ASCII range #975

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix handling of bytes outside ASCII range #975

merged 1 commit into from
Oct 18, 2023

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Oct 18, 2023

No description provided.

@mdwagner
Copy link
Contributor

mdwagner commented Oct 18, 2023 •
edited
Loading

https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS-ESCAPE

As of postgres 9.1, the server defaults to not auto escaping backslashes, so this PR makes sense. We should also raise this with pg shard, as I think their implementation is outdated (or could be adjusted).

will/crystal-pg#22

jwoertink
jwoertink approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this fix!

@jwoertink jwoertink merged commit c592af6 into luckyframework:main Oct 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manveru @mdwagner @jwoertink