Cyberware/bioware incompatibilities #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevnull
changed the title
|
Sorry, just noticed this PR. I think the datajack code is worth keeping, because there's no coded reason to have multiple datajacks, so it will just risk costing essence when someone doesn't need to spend it. I don't want people picking up essence holes because they did their operations out of order. |
|
Technically, different datajacks are blocked by different types of clothing (e.g., helmets, gloves), so there can be a very minor benefit in ease of jacking in when switching out equipment configurations, in addition to RP support. Though it looks like normal datajacks will still be incompatible with induction datajacks since they're both type cyb_datajack. I'll go ahead and revert that bit since it's incomplete anyway. |
This reverts commit b66bad2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add guard for metabolic arrester incompatibilities. According to MM pg 67, the metabolic arrester is not compatible with the adrenal pump or suprathyroid gland.
Remove guard preventing datajack + eye datajack. Multiple datajacks is not unusual in canon (SR3 pg 298), and the
get_datajackfunction is able to handle multiple datajacks.