Miscellaneous Fixes #720
Merged
Miscellaneous Fixes #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MM pg 30 states that move-by-wire is not compatible with any other reaction or initiative enhancing cyberware or bioware. Also, there was previously no check preventing them from stacking with magic/adept reaction/initiative bonuses. This PR ensures that they don't stack in either case.
When leaving chargen, remaining unspent nuyen are dumped into a housing card in increments of 5k nuyen. This PR lets this happen when the character has exactly 5k nuyen remaining.
The absence of decrease (non-cybered) attribute spells from the chargen health spell instructor appears to be an oversight, given that they already teach decrease cybered attribute, increase (non-cybered) attribute, and increase cybered attribute spells. The decrease (non-cybered) attribute spells can be used as debuffs against NPC opponents and would allow healer totem shamanists to have an offensive spell option. If anything, it should be the decrease cybered versions that should be absent, since they are only really used to make subsequent increase cybered spells easier (where using ritualcast instead would be preferred anyway).
The previous attempt at preventing persona programs from using storage memory in store-bought decks failed because it was placed in a block requiring GET_OBJ_TYPE(cont) == ITEM_DECK_ACCESSORY. This PR moves the fix to the right place. This answers: https://discord.com/channels/564618629467996170/788953927269613608/1172638603009081464