Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added helicopter icon #2760

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

liloudreams
Copy link

What is the purpose of this pull request?

  • New Icon

Description

Added new helicopter icon.

Icon use case

  • Used on transportation and aviation platforms for helicopter-related services, such as air travel, emergency medical transport, or private charter bookings.
  • Representing aerial logistics, rescue operations, or VIP transport in aviation and emergency response applications.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: Plane, Armchair
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/helicopter.json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Added or changed icons

icons/helicopter.svg

Preview cohesion icons/square-code.svg
icons/helicopter.svg
icons/filter-x.svg
Preview stroke widths icons/helicopter.svg
icons/helicopter.svg
icons/helicopter.svg
DPI Preview (24px) icons/helicopter.svg
Icon X-rays icons/helicopter.svg
Icon Diffs icons/helicopter.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const HelicopterIcon = createLucideIcon('Helicopter', [
  ["path",{"d":"M11 17V21"}],
  ["path",{"d":"M14 7C11 7 8 9 8 12"}],
  ["path",{"d":"M14 7C19 7 22 10 22 13"}],
  ["path",{"d":"M14 7V11C14 12 15 13 16 13H22"}],
  ["path",{"d":"M14 7V3"}],
  ["path",{"d":"M17 17H11"}],
  ["path",{"d":"M17 17V21"}],
  ["path",{"d":"M17 21L11 21"}],
  ["path",{"d":"M2 17H8"}],
  ["path",{"d":"M2 17V12"}],
  ["path",{"d":"M2 17V15L8 12"}],
  ["path",{"d":"M21 21H17"}],
  ["path",{"d":"M22 13C22 16 20 17 17 17"}],
  ["path",{"d":"M5.97 3H22"}],
  ["path",{"d":"M7 21H11"}],
  ["path",{"d":"M8 12V17"}],
  ["path",{"d":"M8 17H11"}]
])

@karsa-mistmere
Copy link
Member

Hey @liloudreams,

Pretty neat icon, but there are a few minor guideline violations mostly concerning gaps, and the icon could be better optimized (there are several paths that could be easily be merged into a single one).

  1. In this part, there's a slight gap violation:

    image

    I tried increasing the gap to meet our guidelines, but that makes the window look far too detached, I would instead suggest that we bring it out to the full width of the body.

  2. The tail also doesn't have a sufficiently large gap within it:

    image
  3. There are also some corners that could be rounded and some, that probably ought not be, e.g. where the tail meets the body, since at 1px that rounding is all but invisible, which makes the icon feel considerably different when scaled up, see:

    image


All in all, I'd suggest these changes (I'm not hell bent on connecting the landing skids, but I think it does help making the icon look more like a helicopter even if there's some added density):

icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Feb 1, 2025

Suggestion with more arcs and a less dense tail:

icons
Open lucide studio

With connected landing gear:
icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Feb 2, 2025

With my less dense tail, we can even move the body a bit to the left and make it more centered.
icons
Open lucide studio

With it being 1px more left we could add an arc to the landing gear:
icons
Open lucide studio

Review gap and stroke violations
@liloudreams
Copy link
Author

Hey @liloudreams,

Pretty neat icon, but there are a few minor guideline violations mostly concerning gaps, and the icon could be better optimized (there are several paths that could be easily be merged into a single one).

  1. In this part, there's a slight gap violation:
    image
    I tried increasing the gap to meet our guidelines, but that makes the window look far too detached, I would instead suggest that we bring it out to the full width of the body.
  2. The tail also doesn't have a sufficiently large gap within it:
    image
  3. There are also some corners that could be rounded and some, that probably ought not be, e.g. where the tail meets the body, since at 1px that rounding is all but invisible, which makes the icon feel considerably different when scaled up, see:
    image

All in all, I'd suggest these changes (I'm not hell bent on connecting the landing skids, but I think it does help making the icon look more like a helicopter even if there's some added density):

iconsOpen lucide studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants