Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added poop icon #2754

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

EthanHazel
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Creates an icon based on the poop emoji

Icon use case

Dead links (similar to discord)
Comedic use
Low quality indicator
Custom emoji

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 25, 2025
Copy link

Added or changed icons

icons/poop.svg

Preview cohesion icons/square-asterisk.svg
icons/poop.svg
icons/square-menu.svg
Preview stroke widths icons/poop.svg
icons/poop.svg
icons/poop.svg
DPI Preview (24px) icons/poop.svg
Icon X-rays icons/poop.svg
Icon Diffs icons/poop.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PoopIcon = createLucideIcon('Poop', [
  ["path",{"d":"M9 9c-1-2 .27-3.27 1-4 1-1 3-2 3-2v2c0 2 .65 2.58 2 3 3 1 3 4 3 4 0 2-3 2-3 2h2c1.66 0 4 1 4 4a3 3 0 0 1-3 3H6a3 3 0 0 1-3-3c0-3 3-4 4-4h2s-3 0-3-2c0 0 0-3 3-3h1"}]
])

@EthanHazel
Copy link
Contributor Author

Fully aware that this icon seems pretty nonsensical but I actually have my own use case for it on my 404 page on my website and decided to submit a pr for it as it was already made

@EthanHazel EthanHazel changed the title Studio/poop feat(icons): added poop icon Jan 25, 2025
@jguddas
Copy link
Member

jguddas commented Jan 26, 2025

From #1465, @danielbayley did a pretty great job there but it didn't make it.

They are a bit big tho.

icons
Open lucide studio

icons
Open lucide studio

@EthanHazel
Copy link
Contributor Author

I feel like they look pretty hard to read to the one I made in comparison. If @danielbayley is okay with it I can merge my icon with his pr or make it an alt design but the pr looks pretty dead and it doesn't look like he's updating it (there's also some issues with it with some icons breaking design guidelines)

@jguddas
Copy link
Member

jguddas commented Jan 26, 2025

Odds are this PR will also die for the same reason, not enough use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants