Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom (same) schedules #139

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bevy_renet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ renet = {path = "../renet", version = "0.0.16", default-features=false, features

[dev-dependencies]
bevy = {version = "0.14", default-features = false, features = ["bevy_core_pipeline", "bevy_render", "bevy_asset", "bevy_pbr", "x11", "tonemapping_luts", "ktx2", "zstd"]}
bincode = "1.3"
env_logger = "0.11"
bincode = "1.3.1"
env_logger = "0.11.0"
serde = {version = "1.0", features = ["derive"]}
2 changes: 0 additions & 2 deletions bevy_renet/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ If you want a more complex example you can checkout the [demo_bevy](https://gith

|bevy|bevy_renet|
|---|---|
|0.14|0.0.12|
|0.13|0.0.11|
|0.12|0.0.10|
|0.11|0.0.9|
|0.10|0.0.8|
Expand Down
8 changes: 4 additions & 4 deletions bevy_renet/examples/simple.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ fn main() {
app.init_resource::<Lobby>();

if is_host {
app.add_plugins(RenetServerPlugin);
app.add_plugins(NetcodeServerPlugin);
app.add_plugins(RenetServerPlugin::default());
app.add_plugins(NetcodeServerPlugin::default());
let (server, transport) = new_renet_server();
app.insert_resource(server);
app.insert_resource(transport);
Expand All @@ -109,8 +109,8 @@ fn main() {
(server_update_system, server_sync_players, move_players_system).run_if(resource_exists::<RenetServer>),
);
} else {
app.add_plugins(RenetClientPlugin);
app.add_plugins(NetcodeClientPlugin);
app.add_plugins(RenetClientPlugin::default());
app.add_plugins(NetcodeClientPlugin::default());
app.init_resource::<PlayerInput>();
let (client, transport) = new_renet_client();
app.insert_resource(client);
Expand Down
48 changes: 41 additions & 7 deletions bevy_renet/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
pub use renet;

use bevy::prelude::*;
use bevy::{
ecs::{intern::Interned, schedule::ScheduleLabel},
prelude::*,
};

use renet::{RenetClient, RenetServer, ServerEvent};

Expand All @@ -25,19 +28,47 @@ pub struct RenetReceive;
#[derive(Debug, SystemSet, Clone, Copy, PartialEq, Eq, Hash)]
pub struct RenetSend;

pub struct RenetServerPlugin;

pub struct RenetClientPlugin;
#[derive(Debug, SystemSet, Clone, Copy, PartialEq, Eq, Hash)]
pub enum CoreSet {
Pre,
Post,
}
#[derive(Clone, Copy)]
pub struct NetSchedules {
pub pre: Interned<dyn ScheduleLabel>,
pub post: Interned<dyn ScheduleLabel>,
}
impl Default for NetSchedules {
fn default() -> Self {
Self {
pre: PreUpdate.intern(),
post: PostUpdate.intern(),
}
}
}
#[derive(Default)]
pub struct RenetServerPlugin {
pub schedules: NetSchedules,
}
#[derive(Default)]
pub struct RenetClientPlugin {
pub schedules: NetSchedules,
}

impl Plugin for RenetServerPlugin {
fn build(&self, app: &mut App) {
app.init_resource::<Events<ServerEvent>>();
app.add_systems(PreUpdate, Self::update_system.run_if(resource_exists::<RenetServer>));
app.add_systems(
PreUpdate,
self.schedules.pre,
Self::update_system.in_set(CoreSet::Pre).run_if(resource_exists::<RenetServer>),
);
app.add_systems(
self.schedules.pre,
Self::emit_server_events_system
.in_set(RenetReceive)
.run_if(resource_exists::<RenetServer>)
.in_set(CoreSet::Pre)
.run_if(resource_exists::<RenetServer>)
.after(Self::update_system),
);
}
Expand All @@ -57,7 +88,10 @@ impl RenetServerPlugin {

impl Plugin for RenetClientPlugin {
fn build(&self, app: &mut App) {
app.add_systems(PreUpdate, Self::update_system.run_if(resource_exists::<RenetClient>));
app.add_systems(
self.schedules.pre,
Self::update_system.in_set(CoreSet::Pre).run_if(resource_exists::<RenetClient>),
);
}
}

Expand Down
31 changes: 20 additions & 11 deletions bevy_renet/src/transport.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,41 @@ use renet::{

use bevy::{app::AppExit, prelude::*};

use crate::{RenetClientPlugin, RenetReceive, RenetSend, RenetServerPlugin};
use crate::{CoreSet, NetSchedules, RenetClientPlugin, RenetReceive, RenetSend, RenetServerPlugin};

pub struct NetcodeServerPlugin;

pub struct NetcodeClientPlugin;
#[derive(Default)]
pub struct NetcodeServerPlugin {
pub schedules: NetSchedules,
}
#[derive(Default)]
pub struct NetcodeClientPlugin {
pub schedules: NetSchedules,
}

impl Plugin for NetcodeServerPlugin {
fn build(&self, app: &mut App) {
app.add_event::<NetcodeTransportError>();

app.add_systems(
PreUpdate,
self.schedules.pre,
Self::update_system
.in_set(RenetReceive)
.in_set(CoreSet::Pre)
.run_if(resource_exists::<NetcodeServerTransport>)
.run_if(resource_exists::<RenetServer>)
.after(RenetServerPlugin::update_system)
.before(RenetServerPlugin::emit_server_events_system),
);

app.add_systems(
PostUpdate,
self.schedules.post,
(Self::send_packets.in_set(RenetSend), Self::disconnect_on_exit)
.run_if(resource_exists::<NetcodeServerTransport>)
.run_if(resource_exists::<RenetServer>),
.run_if(resource_exists::<RenetServer>).in_set(CoreSet::Post),
);
if self.schedules.post == self.schedules.pre {
app.configure_sets(self.schedules.post, (CoreSet::Pre, CoreSet::Post).chain());
}
}
}

Expand Down Expand Up @@ -62,18 +71,18 @@ impl Plugin for NetcodeClientPlugin {
app.add_event::<NetcodeTransportError>();

app.add_systems(
PreUpdate,
self.schedules.pre,
Self::update_system
.in_set(RenetReceive)
.run_if(resource_exists::<NetcodeClientTransport>)
.run_if(resource_exists::<RenetClient>)
.after(RenetClientPlugin::update_system),
.after(RenetClientPlugin::update_system).in_set(CoreSet::Pre),
);
app.add_systems(
PostUpdate,
self.schedules.post,
(Self::send_packets.in_set(RenetSend), Self::disconnect_on_exit)
.run_if(resource_exists::<NetcodeClientTransport>)
.run_if(resource_exists::<RenetClient>),
.run_if(resource_exists::<RenetClient>).in_set(CoreSet::Post),
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion demo_bevy/src/bin/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ fn add_steam_network(app: &mut App) {
fn main() {
let mut app = App::new();
app.add_plugins(DefaultPlugins);
app.add_plugins(RenetClientPlugin);
app.add_plugins(RenetClientPlugin::default());
app.add_plugins(LookTransformPlugin);
app.add_plugins(FrameTimeDiagnosticsPlugin);
app.add_plugins(LogDiagnosticsPlugin::default());
Expand Down
2 changes: 1 addition & 1 deletion demo_bevy/src/bin/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ fn main() {
let mut app = App::new();
app.add_plugins(DefaultPlugins);

app.add_plugins(RenetServerPlugin);
app.add_plugins(RenetServerPlugin::default());
app.add_plugins(FrameTimeDiagnosticsPlugin);
app.add_plugins(LogDiagnosticsPlugin::default());
app.add_plugins(EguiPlugin);
Expand Down