PauseMenuScripting: resolve absolute 'builtin' path before substring check #15720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check In 99% of the cases, this behaviour is identical to before. With this commit, it is again possible to have 'builtin' a symlink that e.g. points to the engine source directory, which is helpful for development purposes.
sfan5
reviewed
Jan 27, 2025
sfan5
approved these changes
Jan 27, 2025
grorp
reviewed
Jan 29, 2025
grorp
added
the
Action / change needed
grorp
added
>= Two approvals ✅ ✅
and removed
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 99% of the cases, this behaviour is identical to before. With this commit, it is again possible to have 'builtin' a symlink that e.g. points to the engine source directory, which is helpful for development purposes.
This was changed in eeb6cab and immediately broke my build setup. Hence this PR.
I also think that
getClient()->getBuiltinLuaPath()is safer, asRUN_IN_PLACE=1builds might havepath_userandpath_sharein the same place, which can result in erroneously picking the wrong path [during development].To do
This PR is Ready for Review.
How to test