Add the ability to print out server info. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this allows the HTTPS public key to be printed so that one can verify that the browser is actually connecting to the expected server. For example: ``` $ cargo run info pizauth version 1.0.5: cache directory: /tmp/runtime-ltratt/pizauth config file: /home/ltratt/.config/pizauth.conf server running: HTTP port: 7470 HTTPS port: 24004 HTTPS public key: 04:70:57:B0:9A:B4:1C:F9:CB:2E:33:CB:71:D9:B1:7C:5C:6E:84:8F:25:66:F4:C8:1E:3F:41:F8:34:8D:2A:6A:3F:26:D9:A6:57:27:D0:B0:93:09:5B:50:70:D9:DD:1A:A0:DE:33:04:E1:A8:FB:C6:30:D2:92:B1:26:11:E5:75:B9 ``` Note this requires a bump to the JSON info version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this allows the HTTPS public key to be printed so that one can verify that the browser is actually connecting to the expected server. For example:
Note this requires a bump to the JSON info version.
@trembel This solves the major remaining weakness with the HTTPS support as I see it. Of course, one could always do more e.g. allowing users to specify their own certificates. But this feels like it's enough for someone to have confidence in the HTTPS support in pizauth. Does it work as expected for you?