Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add temperature attribute to ATAOS applyCorrection #905

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Add temperature attribute to ATAOS applyCorrection #905

merged 3 commits into from
Sep 23, 2024

Conversation

gmegh
Copy link
Contributor

@gmegh gmegh commented Sep 8, 2024

No description provided.

@gmegh gmegh requested a review from tribeiro September 8, 2024 19:56
tribeiro
tribeiro requested changes Sep 8, 2024
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add temperature attributes to all the relevant events e.g.:

@gmegh
Copy link
Contributor Author

gmegh commented Sep 8, 2024

I think I have added them to all of the events

@gmegh gmegh requested a review from tribeiro September 8, 2024 21:40
tribeiro
tribeiro reviewed Sep 9, 2024
View reviewed changes
doc/news/interface_changes/DM-46190.ataos.rst Outdated
@@ -0,0 +1 @@
Add temperature attribute to ATAOS_command_applyCorrection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, mention that you are also adding it to the events.

@gmegh gmegh requested a review from tribeiro September 9, 2024 19:38
tribeiro
tribeiro approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@gmegh gmegh merged commit ec52d38 into develop Sep 23, 2024
6 checks passed
@gmegh gmegh deleted the tickets/DM-46190 branch September 23, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tribeiro tribeiro tribeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmegh @tribeiro