DM-46165: adding optical configuration to TunableLaser XML #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Looks good.
However, I would suggest you track down the commands/events that this enumeration is used and mention in the attribute description that the field is an enum, e.g;
<EFDB_Name>configuration</EFDB_Name>
<Description>The new optical alignment configuration; a OpticalConfiguration enum.</Description>
tribeiro
requested changes
Sep 12, 2024
parfa30
force-pushed
the
tickets/DM-46165
branch
from
0dbd9f3
to
d5f0874
Compare
tribeiro
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to move the Optical Configuration enum from ts_TunableLaser to ts_xml so that we can change the optical configuration in scripts. This is necessary because we will swap between F1, F2 and direct for different tests.