DM-45874: Update MTMount telemetry with latest version from Tekniker. #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvreeven
requested changes
Aug 21, 2024
| @@ -9,7 +9,6 @@ | |||
| <SALTelemetry> | |||
| <Subsystem>MTMount</Subsystem> | |||
| <EFDB_Topic>MTMount_azimuth</EFDB_Topic> | |||
| <Description>Azimuth axis detail</Description> | |||
There was a problem hiding this comment.
Why did you remove this and all other topic descriptions? There is a unit test that checks if all topics have descriptions so that should fail now. See https://github.com/lsst-ts/ts_xml/blob/develop/tests/test_TopicDescription.py#L20-L21 why it doesn't.
wvreeven
reviewed
Aug 21, 2024
| @@ -10,6 +10,13 @@ | |||
| <Subsystem>MTMount</Subsystem> | |||
| <EFDB_Topic>MTMount_command_openMirrorCovers</EFDB_Topic> | |||
| <Description>Open the mirror covers to allow light in. Warning: This terminology may be the opposite of that used by the Engineering User Interface.</Description> | |||
| <item> | |||
| <EFDB_Name>leaf</EFDB_Name> | |||
| <Description>Specify a leaf to open. By default (leaf=0) open all.</Description> | |||
There was a problem hiding this comment.
What other values are possible? I assume it is a single value for a specific leaf. What are the valid values and to which leafs do they correspond? Please introduce an enum for all values and to which leaf they correspond and indicate here that that enum should be used.
tribeiro
force-pushed
the
tickets/DM-45874
branch
from
e5983e5
to
cd270c2
Compare
tribeiro
force-pushed
the
tickets/DM-45874
branch
from
cd270c2
to
9baa176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.