DM-43090: next-visit-fan-out for LSSTComCamSim for dev #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes of variable names: - lsst_com_cam_active_detectors -> lsstcomcam_active_detectors - lsst_cam_active_detectors -> lsstcam_active_detectors - lsst_cam_knative_serving_url -> lsstcam_knative_serving_url - LSST_CAM_KNATIVE_SERVING_URL -> LSSTCAM_KNATIVE_SERVING_URL Take out the underscores in the camera names, so a camera name is one simplier string like other references in this file.
hsinfang
force-pushed
the
tickets/DM-43090
branch
from
ef3b566
to
53013b4
Compare
hsinfang
commented
Feb 29, 2024
kfindeisen
approved these changes
Feb 29, 2024
| @@ -159,6 +159,7 @@ async def main() -> None: | |||
| offset = os.environ["OFFSET"] | |||
| kafka_schema_registry_url = os.environ["KAFKA_SCHEMA_REGISTRY_URL"] | |||
| latiss_knative_serving_url = os.environ["LATISS_KNATIVE_SERVING_URL"] | |||
| lsstcomcam_knative_serving_url = os.environ["LSSTCOMCAM_KNATIVE_SERVING_URL"] | |||
There was a problem hiding this comment.
I guess we already have a URL defined in the Phalanx config, but this makes me a bit nervous -- trying to support all the instruments in advance has caused us a lot of unnecessary maintenance on the Phalanx side...
There was a problem hiding this comment.
I share your concern. Maybe we should refactor next_visit_fan_out a bit, but don't have a plan right now.
This added variable lsstcomcam_knative_serving_url isn't really used yet, but is expected later.
hsinfang
force-pushed
the
tickets/DM-43090
branch
from
53013b4
to
50bf368
Compare
|
My thinking on adding the ComCam part is that the LSSTCam counterpart already exists but ComCam partially exists. I would prefer either they all exist or they all don't exist. So instead of removing the existing pieces, I opted for completing (to my best effort) the ComCam counterpart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.