Fix the JDK version range for jdk9 profile #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR requires #249 for the CI job to be successful. |
rouazana
approved these changes
Nov 14, 2023
The version range was: `[9,11[` was leading to activation of `jdk9` profile when running on Java 11. This can be confirmed by running: `mvn help:active-profiles`. Actually `[9,11[` is not a valid range definition according to https://maven.apache.org/ref/3.9.5/maven-artifact/apidocs/org/apache/maven/artifact/versioning/VersionRange.html#createFromVersionSpec(java.lang.String) This change update the definition of version range to `[9,11)` that actually exclude Java 11 (`jdk11` will be activated in such situation).
amottier
force-pushed
the
fix-jdk9-profile-activation
branch
from
b6dd4cc
to
bedb3e0
Compare
|
Rebase is done @rouazana PR should be ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version range was:
[9,11[leading to activation ofjdk9profile when running on Java 11. This can be confirmed by running:mvn help:active-profiles. Actually[9,11[is not a valid range definition according to https://maven.apache.org/ref/3.9.5/maven-artifact/apidocs/org/apache/maven/artifact/versioning/VersionRange.html#createFromVersionSpec(java.lang.String) This change update the definition of version range to[9,11)that actually exclude Java 11 (jdk11will be activated in such situation).