Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add systemd unitfiles #247

Closed
wants to merge 38 commits into from
Closed

Add systemd unitfiles #247

wants to merge 38 commits into from

Conversation

xavierba
Copy link
Contributor

@xavierba xavierba commented Nov 6, 2023

This applies on top of the RPM spec file cleanup merge request #246.
It fixes #50. This is different enough from what @davidcoutadeur did in #230, so I'd rather not try to improve #230 and submit a new one.
And indeed, thank you very much @davidcoutadeur, all your inputs were invaluable and I wouldn't have gone this far without you :-)

@xavierba
Drop deprecated Group: tag
fc0f0da
@xavierba
Drop deprecated Buildroot tag
814dc0a
@xavierba
Drop deprecated clean of buildroot in %%install
b01fb21
@xavierba
Drop deprecated clean of buildroot in %%clean
64f29a6
@xavierba
Drop %%defattr from top of %%files, this is the default
9eaface
@xavierba
Update License: tag to SPDX and distribute the license file
50634ae
@xavierba
Drop useless lsc_name and lsc_version variables
88cc95d
@xavierba
Use full URL for Source: tag
9ca3627
@xavierba
Use macros instead of straight paths
70986d9
@xavierba
Own /var/lib/lsc
ace880e
@xavierba
Add white lines between changelog entries for legibility
3efb46b
@xavierba
User creation belongs to %%pre, not %%post
73eabf4
@xavierba
Properly own conf dirs and files
7e52179
@xavierba
One must never delete an user/group to prevent possible uid/gid re-use
6e57d55
@xavierba
Make use of %%doc
65ca718
@xavierba
Set logdir ownership in %%files, not in %%post
b2a55ae
@xavierba
Quieten %%setup. Also -n %%name-%%version is the default, drop it
c58c756
@xavierba
Fix initscript scriptlets and Requires
d99b289
@xavierba
Re-order preamble
18b6bea
@xavierba
Factorize conf variables substitution
0361a70
@xavierba
Split long lines
5792a98
@xavierba
Replace spurious tabs by spaces
ab9c68f
@xavierba
Install manpages
dfe5f98
@xavierba
Add missing Requires: crontabs
bde5296
@xavierba
Move nagios checks to their own subpackage
ef15bb1
@xavierba
Tune lsc user
cd555a1 
- Add a comment
- Suppress shell
- Change home directory to /var/lib/lsc
@xavierba
Fix various pid files location
beac75f
@xavierba
Drop superfluous comments
492bfc8
@xavierba
Replace %%define with %%global
9d3fdde
@xavierba
Drop symlink hack in %%_docdir
e611170
@davidcoutadeur
Copy link
Contributor

This applies on top of the RPM spec file cleanup merge request #246. It fixes #50. This is different enough from what @davidcoutadeur did in #230, so I'd rather not try to improve #230 and submit a new one. And indeed, thank you very much @davidcoutadeur, all your inputs were invaluable and I wouldn't have gone this far without you :-)

Seems nice.
At first sight, we miss the equivalent for Debian, isn't it? (at least for new systemd service deployments, but ideally for all new changes brought in rpm specfile)

@davidcoutadeur
Copy link
Contributor

As discussed with @xavierba, this MR is obsolete and replaced by #260

#260 only takes care about adding the systemd files. Integration in debian/red-hat will be done elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a systemd script
2 participants
@xavierba @davidcoutadeur