Integrated code lifecycle: Support multiple SSH keys per user

[SimonEntholzer]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
• I strictly followed the principle of data economy for all database calls.
• I strictly followed the server coding and design guidelines.
• I added multiple integration tests (Spring) related to the features (with a high test coverage).
• I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
• I documented the Java code using JavaDoc style.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
• I strictly followed the principle of data economy for all client-server REST calls.
• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
• I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
• I documented the TypeScript code using JSDoc style.
• I added multiple screenshots/screencasts of my UI changes.
• I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

• High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).

Motivation and Context

Adds the feature requested in #9166

Description

Support multiple SSH keys per user.

This PR:

• adds a new table to support multiple SSH keys
• extends the frontend to let users create multiple keys
• enables git operations with the new keys

Steps for Testing

Add ssh keys to your account, and use them to clone different repositories in Artemis.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Client

Class/File	Line Coverage	Confirmation (assert/expect)
account.service.ts	87.71%	✅ ❌
user-ssh-public-key.model.ts	100%	✅
code-button.component.ts	93.37%	✅ ❌
ssh-user-settings-key-details.component.ts	98.61%	✅ ❌
ssh-user-settings.component.ts	94.73%	✅ ❌

Server

Class/File	Line Coverage	Confirmation (assert/expect)
UserRepository.java	89%	✅ ❌
AccountResource.java	93%	✅ ❌
UserSshPublicKey.java	93%	✅ ❌
UserSshPublicKeyDTO.java	100%	✅
UserSshPublicKeyService.java	97%	✅ ❌
GitPublickeyAuthenticatorService.java	83%	✅ ❌

Screenshots

The initial view, when the user does not have any SSH keys:

The SSH key creation view:

The view after the key has been created:

The keys overview page when the user has multiple keys:

Th user can delete keys and view its details:

View details:

Delete the key:

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced SSH key management with new endpoints for adding, retrieving, and deleting SSH keys.
  • Introduction of a new UserSshPublicKey model to encapsulate SSH key details.
  • New component for SSH key details management, supporting both creation and viewing modes.
  • Improved user feedback with detailed error messages for SSH key operations.
  • Added new methods to manage and validate SSH keys, including checks for existing keys and invalid formats.
  • New UserSshPublicKeyDTO for data transfer related to SSH keys.
  • Asynchronous loading and management of SSH keys in user settings components.
  • New routes for SSH user settings, facilitating navigation between adding and viewing SSH keys.

• Bug Fixes

  • Enhanced error handling for invalid SSH key formats and duplication scenarios.

• Documentation

  • Updated user settings translations to reflect new SSH key management features.

• Style

  • Improved UI layout and responsiveness for SSH settings components.
  • Updated styling for dropdowns and buttons in SSH settings to enhance user interaction.

• Tests

  • Expanded test coverage for SSH key management functionalities, including new scenarios for retrieval and validation.
  • Comprehensive unit tests for the new SSH key details component, ensuring robust functionality and error handling.

[BBesrour]

Tested on TS3, from the user-view, works as expected
But the build fails

[Feras797]

Tested on TS3, everything works as expected.
Only one thing I noticed is that it is possible to assign the same label to multiple keys. Not sure if this is supposed to be possible.

[SindiBuklaji]

Tested on TS5. Works as expected 👍

[BBesrour]

re-approve after merge conflicts

[JohannesStoehr]

Reapprove after merge

[az108]

reapprove after merge

[HawKhiem]

Reapprove

[pzdr7]

Code