`General`: Add cleanup service for admins #9296

coolchock · 2024-09-07T13:15:32Z

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.
I added multiple integration tests (Spring) related to the features (with a high test coverage).
I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
I documented the Java code using JavaDoc style.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
I strictly followed the client coding and design guidelines.
Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
I documented the TypeScript code using JSDoc style.
I added multiple screenshots/screencasts of my UI changes.
I translated all newly inserted strings into English and German.

Motivation and Context

Artemis stores a large amount of information, some of which can become corrupted or irrelevant over time. These records occupy significant database space, which can be reclaimed by deleting unused data. This includes old results, unresolved plagiarism cases, and unused feedback.

Currently, there are scripts for cleaning up results and feedback, but no automated process exists for clearing unresolved plagiarism cases. Additionally, orphaned entities, such as results without associated submissions or participation, remain unaddressed, leading to inefficient database usage. Furthermore, these cleanup scripts must be run manually by administrators, which is not ideal. To address these issues, a dedicated cleanup service for administrators was implemented to streamline the process.

Description

A cleanup service has been added to the admin panel, allowing administrators to select specific cleanup operations to perform on the database. They can specify a time period for which the cleanup should be executed, providing flexibility in managing old or unused data. In future iterations, a scheduled job is planned to be introduced, which will automatically execute the cleanup operations periodically, reducing the need for manual intervention and ensuring ongoing database optimization.

Steps for Testing

Prerequisites:

1 Administrator
1 Test Server where you have access rights
Test data generated using large_course_main.py script. See README in the folder quick-course-setup for more details.

Log in to Artemis.
Navigate to course management and select the course created by the script.
Set the start and end dates of the course within the period for which you will delete data.
Open the programming exercise created by the script and go to the Plagiarism section.
Set the threshold to 0 and execute plagiarism detection. You should receive a few results.
In Server Administration -> Cleanup Service, execute "Delete plagiarism comparisons."
Verify that the plagiarism comparisons were deleted.
Execute the "Delete old rated results" operation.
Verify that only the last student submission has a linked result.
Set the end date for the programming exercise to a past date and start a practice mode participation.
In the cleanup service, execute "Delete non-rated results."
Verify that the practice mode submission no longer has a linked result.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

Code Review 1
Code Review 2

Manual Tests

Test 1
Test 2

Performance Tests

Test 1
Test 2

Test Coverage

Info: ✅ ❌ in Confirmation (assert/expect) have to be adjusted manually, also delete trivial files!

Client

Class/File	Line Coverage	Confirmation (assert/expect)
admin.route.ts	not found (modified)	❌
cleanup-operation.model.ts	0%	✅ ❌
cleanup-service.component.ts	82.5%	✅ ❌
data-cleanup.service.ts.ts	100%	✅
date-time-picker.component.ts	96.66%	✅ ❌
navbar.component.ts	87.76%	✅ ❌

Server

Class/File	Line Coverage	Confirmation (assert/expect)
FeedbackRepository.java	86%	✅ ❌
LongFeedbackTextRepository.java	100%	✅
ParticipantScoreRepository.java	81%	✅ ❌
RatingRepository.java	not found (modified)	❌
ResultRepository.java	96%	✅ ❌
StudentScoreRepository.java	not found (modified)	❌
TeamScoreRepository.java	not found (modified)	❌
TextBlockRepository.java	not found (modified)	❌
CleanupJobExecution.java	80%	✅ ❌
CleanupJobType.java	100%	✅
CleanupServiceExecutionRecordDTO.java	100%	✅
CleanupJobExecutionRepository.java	not found (added)	❌
DataCleanupService.java	100%	✅
AdminOldDataCleanupResource.java	100%	✅
PlagiarismComparisonRepository.java	100%	✅

Screenshots

View from the navigation bar

Cleanup service

Confirmation dialog

Summary by CodeRabbit

New Features
- Introduced a new CleanupServiceComponent for managing data cleanup operations in the admin interface.
- Added a new route for the CleanupServiceComponent in the admin module.
- Enhanced the navbar with a new cleanup icon and breadcrumb translation for the cleanup service.
- Added multiple new cleanup repository interfaces and methods for managing orphaned and outdated data across various entities.
- Added new translations for the cleanup service in both German and English.
Bug Fixes
- Clarified transactional behavior in various repository methods to improve code readability.
Documentation
- Added new documentation for the Cleanup Service, detailing data deletion operations and types.
- Updated the index to include the new cleanup service documentation.
Tests
- Added comprehensive integration tests for various cleanup operations to ensure data integrity.

…utions to the database

...ain/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/FeedbackCleanupRepository.java

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8b5eb3d and df5565d.

⛔ Files ignored due to path filters (1)

src/main/resources/config/liquibase/master.xml is excluded by !**/*.xml

📒 Files selected for processing (1)

src/main/webapp/app/admin/admin.route.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/main/webapp/app/admin/admin.route.ts (1)

Pattern src/main/webapp/**/*.ts: angular_style:https://angular.io/guide/styleguide;methods_in_html:false;lazy_loading:true;code_reuse:true;tests:meaningful;types:PascalCase;enums:PascalCase;funcs:camelCase;props:camelCase;no_priv_prefix:true;strings:single_quotes;localize:true;btns:functionality;links:navigation;icons_text:newline;labels:associate;code_style:arrow_funcs,curly_braces,open_braces_same_line,indent_4;memory_leak_prevention:true;routes:naming_schema;chart_framework:ngx-charts;responsive_layout:true

🔇 Additional comments (2)

src/main/webapp/app/admin/admin.route.ts (2)
23-23: LGTM! Import statement follows Angular guidelines.

The import statement follows proper Angular conventions with correct component naming and module organization.

154-160: Verify navbar integration and translations.

The route is properly configured, but let's ensure it's fully integrated with the navigation system.

✅ Verification successful

Route is properly integrated with navbar and translations

The verification confirms that:

The route is referenced in the navbar template (src/main/webapp/app/shared/layouts/navbar/navbar.component.html)

Translation keys exist in both English and German:

Menu item: global.menu.admin.cleanupService

Page title: cleanupService.title

All required table translations in cleanupService.json
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify navbar integration and translations for the cleanup service

# Test 1: Check if the route is referenced in the navbar template
echo "Checking navbar template for cleanup service link..."
rg -l "cleanup-service" "src/main/webapp/app/layouts/"

# Test 2: Verify translation key exists
echo "Checking translation files for 'cleanupService.title'..."
rg -l "cleanupService.title" "src/main/webapp/i18n/"
Length of output: 416

Script:
#!/bin/bash
# Let's try a broader search to locate the navbar and translation files

# Find navbar-related files
echo "Finding navbar-related files..."
fd navbar

# Find translation files
echo "Finding translation files..."
fd "\.json$" --type f

# Once we find the files, let's check their content
echo "Checking for cleanup-service route references..."
rg -l "cleanup-service"

# Check for translation key pattern
echo "Checking for cleanupService translations..."
rg "cleanupService"
Length of output: 37479

src/main/webapp/app/admin/admin.route.ts

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/LongFeedbackTextCleanupRepository.java (1)

35-42: Enhance readability by uppercasing SQL keywords

Per the coding guidelines (sql:uppercase), SQL keywords should be in uppercase to improve readability and maintain consistency across the codebase. Please update the SQL queries in the methods to use uppercase keywords.

Apply these diffs to update the queries:

For deleteLongFeedbackTextForOrphanResult() (lines 35-42):

 @Query("""
-        delete from LongFeedbackText lft
-        where lft.feedback.id in (
-            select f.id
-            from Feedback f
-            where f.result.participation is null
-                and f.result.submission is null
-            )
+        DELETE FROM LongFeedbackText lft
+        WHERE lft.feedback.id IN (
+            SELECT f.id
+            FROM Feedback f
+            WHERE f.result.participation IS NULL
+                AND f.result.submission IS NULL
+            )
        """)

For deleteLongFeedbackTextForOrphanedFeedback() (lines 52-58):

 @Query("""
-        delete from LongFeedbackText lft
-        where lft.feedback in (
-            select f
-            from Feedback f
-            where f.result is null
-            )
+        DELETE FROM LongFeedbackText lft
+        WHERE lft.feedback IN (
+            SELECT f
+            FROM Feedback f
+            WHERE f.result IS NULL
+            )
        """)

For deleteLongFeedbackTextForRatedResultsWhereCourseDateBetween() (lines 73-90):

 @Query("""
-        delete from LongFeedbackText lft
-        where lft.feedback in (
-            select f
-            from Feedback f
-                left join f.result r
-                left join r.participation p
-                left join p.exercise e
-                left join e.course c
-            where f.result.id not in (
-                select max(r2.id)
-                from Result r2
-                where r2.participation.id = p.id
-                    and r2.rated = true
-                )
-                and c.endDate < :deleteTo
-                and c.startDate > :deleteFrom
-            )
+        DELETE FROM LongFeedbackText lft
+        WHERE lft.feedback IN (
+            SELECT f
+            FROM Feedback f
+                LEFT JOIN f.result r
+                LEFT JOIN r.participation p
+                LEFT JOIN p.exercise e
+                LEFT JOIN e.course c
+            WHERE f.result.id NOT IN (
+                SELECT MAX(r2.id)
+                FROM Result r2
+                WHERE r2.participation.id = p.id
+                    AND r2.rated = TRUE
+                )
+                AND c.endDate < :deleteTo
+                AND c.startDate > :deleteFrom
+            )
        """)

For deleteLongFeedbackTextForNonRatedResultsWhereCourseDateBetween() (lines 105-122):

 @Query("""
-        delete from LongFeedbackText lft
-        where lft.feedback in (
-            select f
-            from Feedback f
-                left join f.result r
-                left join r.participation p
-                left join p.exercise e
-                left join e.course c
-            where f.result.id not in (
-                select max(r2.id)
-                from Result r2
-                where r2.participation.id = p.id
-                    and r2.rated = false
-                )
-                and c.endDate < :deleteTo
-                and c.startDate > :deleteFrom
-            )
+        DELETE FROM LongFeedbackText lft
+        WHERE lft.feedback IN (
+            SELECT f
+            FROM Feedback f
+                LEFT JOIN f.result r
+                LEFT JOIN r.participation p
+                LEFT JOIN p.exercise e
+                LEFT JOIN e.course c
+            WHERE f.result.id NOT IN (
+                SELECT MAX(r2.id)
+                FROM Result r2
+                WHERE r2.participation.id = p.id
+                    AND r2.rated = FALSE
+                )
+                AND c.endDate < :deleteTo
+                AND c.startDate > :deleteFrom
+            )
        """)

Also applies to: 52-58, 73-90, 105-122

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between df5565d and ff94897.

📒 Files selected for processing (7)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/FeedbackCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/LongFeedbackTextCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/PlagiarismComparisonCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/StudentScoreCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/TeamScoreCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/TextBlockCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/communication/repository/FaqRepository.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (6)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/FeedbackCleanupRepository.java
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/PlagiarismComparisonCleanupRepository.java
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/StudentScoreCleanupRepository.java
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/TeamScoreCleanupRepository.java
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/TextBlockCleanupRepository.java
src/main/java/de/tum/cit/aet/artemis/communication/repository/FaqRepository.java

🧰 Additional context used

📓 Path-based instructions (1)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/LongFeedbackTextCleanupRepository.java (1)

Pattern src/main/java/**/*.java: naming:CamelCase; principles:{single_responsibility,small_methods,no_duplication}; db:{perf_queries,datetime_not_timestamp}; rest:{stateless,singleton,delegate_logic,http_only,minimal_dtos}; dtos:{java_records,no_entities,min_data,single_resp}; di:constructor_injection; kiss:simple_code; file_handling:os_indep_paths; practices:{least_access,avoid_transactions,code_reuse,static_member_ref,prefer_primitives}; sql:{param_annotation,uppercase,avoid_subqueries};java:avoid_star_imports

🔇 Additional comments (1)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/LongFeedbackTextCleanupRepository.java (1)

26-124: Overall implementation adheres to best practices

The repository interface is well-defined, and the methods align with the cleanup objectives described in the PR. The use of appropriate annotations and parameterization is consistent with the coding guidelines.

… into feature/general/cleanup-service

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (3)

31-31: Improve transaction documentation.

The comment "ok because of delete" doesn't provide sufficient context about why this transaction is acceptable despite the avoid_transactions guideline. Consider expanding the documentation to explain the necessity of the transaction for data consistency in this cleanup operation.

74-80: Enhance method documentation.

While the documentation explains the purpose, it would be helpful to add:

Expected behavior for edge cases (e.g., what happens if there are multiple results with the same timestamp?)

Performance characteristics for large datasets

Example scenarios showing the before and after state

1-105: Consider performance impact of cleanup operations.

The cleanup operations involve complex queries and deletions that could impact system performance. Consider:

Adding batch processing to handle large deletions

Implementing rate limiting or chunking for large datasets

Adding monitoring/logging to track cleanup operation duration and impact

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ff94897 and ab28dd2.

📒 Files selected for processing (4)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/FeedbackRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (1 hunks)
src/main/webapp/i18n/de/global.json (1 hunks)
src/main/webapp/i18n/en/global.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/FeedbackRepository.java

🧰 Additional context used

📓 Path-based instructions (2)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (1)

Pattern src/main/java/**/*.java: naming:CamelCase; principles:{single_responsibility,small_methods,no_duplication}; db:{perf_queries,datetime_not_timestamp}; rest:{stateless,singleton,delegate_logic,http_only,minimal_dtos}; dtos:{java_records,no_entities,min_data,single_resp}; di:constructor_injection; kiss:simple_code; file_handling:os_indep_paths; practices:{least_access,avoid_transactions,code_reuse,static_member_ref,prefer_primitives}; sql:{param_annotation,uppercase,avoid_subqueries};java:avoid_star_imports

src/main/webapp/i18n/de/global.json (1)

Pattern src/main/webapp/i18n/de/**/*.json: German language translations should be informal (dutzen) and should never be formal (sietzen). So the user should always be addressed with "du/dein" and never with "sie/ihr".

🔇 Additional comments (4)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (2)
1-25: LGTM! Well-structured repository interface.

The class is well-organized with proper imports, documentation, and Spring annotations. It follows the repository pattern and Java conventions.

61-62: Review date range logic.

The current date conditions c.endDate < :deleteTo AND c.startDate > :deleteFrom might be counterintuitive. This would only match courses that:

Started after the deleteFrom date

Ended before the deleteTo date

This means a course that spans the entire period would be excluded. Consider if you meant:
c.startDate < :deleteTo AND c.endDate > :deleteFrom
src/main/webapp/i18n/en/global.json (1)

119-120: LGTM! The new menu entry follows existing conventions.

The addition of the "cleanupService" entry in the admin menu section is appropriate and well-placed. The key and value follow the established naming conventions (camelCase for keys, Title Case for values) used throughout the file, maintaining consistency with other menu items.

src/main/webapp/i18n/de/global.json (1)

119-120: LGTM! The translation and placement look good.

The German translation "Aufräumdienst" for the cleanup service is appropriate and follows the informal language requirement. The entry is properly placed within the admin section.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ab28dd2 and a03e853.

📒 Files selected for processing (2)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/core/service/cleanup/DataCleanupService.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/main/java/de/tum/cit/aet/artemis/core/service/cleanup/DataCleanupService.java

🧰 Additional context used

📓 Path-based instructions (1)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (1)

Pattern src/main/java/**/*.java: naming:CamelCase; principles:{single_responsibility,small_methods,no_duplication}; db:{perf_queries,datetime_not_timestamp}; rest:{stateless,singleton,delegate_logic,http_only,minimal_dtos}; dtos:{java_records,no_entities,min_data,single_resp}; di:constructor_injection; kiss:simple_code; file_handling:os_indep_paths; practices:{least_access,avoid_transactions,code_reuse,static_member_ref,prefer_primitives}; sql:{param_annotation,uppercase,avoid_subqueries};java:avoid_star_imports

🔇 Additional comments (3)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (3)

1-26: LGTM! Well-structured repository interface.

The class follows all coding guidelines including proper package naming, specific imports (no star imports), and appropriate Spring annotations.

28-39: LGTM! Clean and efficient orphaned result cleanup.

The method follows SQL best practices with uppercase keywords and uses appropriate annotations. The transaction usage is properly justified in the comment.

41-54: LGTM! Well-optimized query for latest results.

The method is well-documented and implements an efficient query pattern using MAX and GROUP BY without subqueries.

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java

This reverts commit a03e853.

…queries

coderabbitai

Actionable comments posted: 16

🧹 Outside diff range and nitpick comments (7)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (1)

73-81: Enhance method documentation with performance implications.

While the documentation clearly explains the functionality, it would be helpful to add information about:

Expected execution time for large datasets
Potential impact on database performance during deletion
Recommended batch size or time window constraints

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ParticipantScoreCleanupRepository.java (1)

24-32: Enhance method documentation

While the documentation is thorough, consider adding:

Example usage scenarios
Information about potential exceptions
Explicit mention of void return type

Example enhancement:

/**
 * Deletes {@link ParticipantScore} entries where the associated {@link Result} is not the latest rated result
 * for a {@link Participation}, within courses conducted between the specified date range.
 * This query removes participant scores linked to results that are not the most recent rated results, for courses
 * whose end date is before {@code deleteTo} and start date is after {@code deleteFrom}.
 *
 * @param deleteFrom the start date for selecting courses
 * @param deleteTo   the end date for selecting courses
 * @return void
 * @throws IllegalArgumentException if deleteFrom is after deleteTo
 * 
 * Example:
 * <pre>
 * ZonedDateTime from = ZonedDateTime.now().minusYears(1);
 * ZonedDateTime to = ZonedDateTime.now();
 * repository.deleteParticipantScoresForNonLatestLastResultsWhereCourseDateBetween(from, to);
 * </pre>
 */

Also applies to: 56-64, 88-96, 119-128

src/test/java/de/tum/cit/aet/artemis/core/CleanupIntegrationTest.java (4)

60-60: Add class-level documentation.

Add a comprehensive Javadoc comment to describe the purpose of this integration test class, the cleanup operations being tested, and any important setup requirements.

Example:

/**
 * Integration tests for the cleanup service that handles deletion of outdated or irrelevant data.
 * Tests cover:
 * - Deletion of orphaned entities (feedback, scores, results)
 * - Cleanup of old plagiarism comparisons
 * - Removal of non-rated and rated results
 * - Access control for cleanup operations
 *
 * The tests use two courses (old and new) to verify that cleanup operations correctly target
 * data based on course dates while preserving current data.
 */
@IntegrationTest
class CleanupIntegrationTest extends AbstractSpringIntegrationJenkinsGitlabTest {

64-66: Document date constants and their significance.

The date constants DELETE_FROM and DELETE_TO lack documentation explaining their purpose and why these specific time ranges were chosen.

Add comments to explain:

/**
 * Start date for cleanup operations, set to 12 months ago to cover old data
 */
private static final ZonedDateTime DELETE_FROM = ZonedDateTime.now().minusMonths(12);

/**
 * End date for cleanup operations, set to 6 months ago to preserve recent data
 */
private static final ZonedDateTime DELETE_TO = ZonedDateTime.now().minusMonths(6);

536-548: Enhance helper method documentation and validation.

The createFeedbackWithLinkedLongFeedback method needs documentation and validation.

Add Javadoc and validation:

/**
 * Creates a Feedback entity with an associated LongFeedbackText.
 * The text content is generated using the feedback's hashcode.
 *
 * @return The persisted Feedback entity with linked LongFeedbackText
 */
private Feedback createFeedbackWithLinkedLongFeedback() {
    Objects.requireNonNull(feedbackRepository, "FeedbackRepository must be initialized");
    
    Feedback feedback = new Feedback();
    feedback = feedbackRepository.save(feedback);
    // ... rest of the method
}

550-556: Add validation to createTextBlockForFeedback.

The createTextBlockForFeedback method should validate its input parameter.

Add validation:

/**
 * Creates a TextBlock entity associated with the given Feedback.
 * The text content is generated using the feedback's hashcode.
 *
 * @param feedback The Feedback entity to associate with the TextBlock
 * @return The persisted TextBlock entity
 * @throws IllegalArgumentException if feedback is null
 */
private TextBlock createTextBlockForFeedback(Feedback feedback) {
    Objects.requireNonNull(feedback, "Feedback must not be null");
    Objects.requireNonNull(textBlockRepository, "TextBlockRepository must be initialized");
    
    TextBlock textBlock = new TextBlock();
    textBlock.setFeedback(feedback);
    textBlock.setText("text" + feedback.hashCode());
    textBlock.computeId();
    return textBlockRepository.save(textBlock);
}

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/FeedbackCleanupRepository.java (1)

109-109: Use lowercase Boolean literals in JPQL queries

In the query for deleteOldNonRatedFeedbackWhereCourseDateBetween(), the condition AND r.rated = FALSE uses uppercase FALSE. JPQL recognizes lowercase true and false literals.

Consider changing FALSE to lowercase false for consistency and correctness:

-                    AND r.rated = FALSE
+                    AND r.rated = false

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a03e853 and 86c32b3.

📒 Files selected for processing (7)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/FeedbackCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/LongFeedbackTextCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ParticipantScoreCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/ResultCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/TextBlockCleanupRepository.java (1 hunks)
src/main/java/de/tum/cit/aet/artemis/core/service/cleanup/DataCleanupService.java (1 hunks)
src/test/java/de/tum/cit/aet/artemis/core/CleanupIntegrationTest.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/main/java/de/tum/cit/aet/artemis/assessment/repository/cleanup/TextBlockCleanupRepository.java

🧰 Additional context used

📓 Path-based instructions (6)