-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assessment
: Fix an issue where deleting one unsaved inline feedback deletes all unsaved feedbacks
#7716
Conversation
Manual assessment
: Fix an issue where deleting an unsaved comment deletes all unsaved commentsManual assessment
: Fix an issue where deleting an unsaved inline feedback deletes all unsaved inline feedbacks
Manual assessment
: Fix an issue where deleting an unsaved inline feedback deletes all unsaved inline feedbacksAssessment
: Fix an issue where deleting an unsaved inline feedback deletes all unsaved inline feedbacks
Assessment
: Fix an issue where deleting an unsaved inline feedback deletes all unsaved inline feedbacksProgramming exercises
, Manual assessment
: Fix an issue where deleting a single unsaved comment deletes all unsaved comments
Programming exercises
, Manual assessment
: Fix an issue where deleting a single unsaved comment deletes all unsaved commentsAssessment
: Fix an issue where deleting an unsaved inline feedback deletes all unsaved feedbacks
Hijacking this PR for a short test, will revert afterwards :D |
94d8af6
to
c0b801e
Compare
c0b801e
to
7530b35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve, tested on legacy ts11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts5. Worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested manually on ts2, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS2, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts11, works as described
Assessment
: Fix an issue where deleting an unsaved inline feedback deletes all unsaved feedbacksAssessment
: Fix an issue where deleting one unsaved inline feedback deletes all unsaved feedbacks
c8566db
just waiting for the checks to pass, then I will merge this PR |
Checklist
General
Client
Motivation and Context
Closes #7709
Description
To correctly identify the feedback that should be deleted before it has been saved for the first time, the line, file and content of the feedback are now taken into consideration in addition to the id.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests