Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DoS thumbnail generation exploit #777

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Jan 25, 2021

  1. Limit thumbnail generation

    * This fixes a denial-of-service exploit that would allow the client to
    generate an infinite number of thumbnails and fill up the storage completely.
    Since the client had control over the requested thumbnail sizes, it could make arbitrary requests for thumbnails, and every time the backend did not find an already generated thumbnail with the specified sizes, it would happily generate a new one.
    * Remove the ability of the client to decide thumbnail dimensions and
    only let the back-end do this by reading the configuration.
    * Limit the number of generated thumbnails per file to only one, with
    "landscape" dimensions (4/3).
    * Use CSS "object-fit" property to adjust displaying of landscape thumbnails into squares. Ref: https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit
    glubsy committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    2582d22 View commit details
    Browse the repository at this point in the history
  2. Remove redundant request for square thumb

    * We now use only one thumbnail file src for both square and rational
    thumbnails so remove superfluous requests.
    * Set the same src for both square and landscape dom classes.
    glubsy committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    a2d21cf View commit details
    Browse the repository at this point in the history
  3. Reduce superfluous computations

    Only compute thumbnail configured dimensions on thumbnail API requests.
    glubsy committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    e876184 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Fix typo.

    glubsy committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    ba6b01a View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2021

  1. Remove client-side sample request for img

    * Down-sampling should only be requested by the backend.
    * For now remove the client-side logic entirely since it is both
    superfluous and vulnerable. This can be implemented again on the
    back-end if necessary.
    glubsy committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    4a3dd10 View commit details
    Browse the repository at this point in the history