Bugfixes on Android iBeacon monitoring #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone should be handling these PRs. |
vinceramcesoliveros
approved these changes
Aug 29, 2018
vinceramcesoliveros
suggested changes
Aug 29, 2018
| @@ -44,7 +44,7 @@ class BeaconRegionIBeacon extends BeaconRegion { | |||
|
|
|||
| String get proximityUUID => ids[0]; | |||
|
|
|||
| int get major => ids.length > 1 ? ids[1] : null; | |||
| String get major => ids.length > 1 ? ids[1] : null; | |||
There was a problem hiding this comment.
Tested this one on his example and it doesn't detect any beacons.
You're supposed to convert the Major and Minor to int or decimal.
changing it to string will convert the ids to string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed beacon major and minor ids to String in BeaconRegionIBeacon to prevent parsing errors, removed unbind function