Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(import): remove camel casing in alias #223

Merged
merged 1 commit into from
Sep 20, 2024
Merged

style(import): remove camel casing in alias #223

merged 1 commit into from
Sep 20, 2024

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue None

What this PR does / why we need it:

Update the import alias to remove camel casing to align it with the naming convention used in other Longhorn repos.

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Sep 20, 2024
@c3y1huang c3y1huang marked this pull request as ready for review September 20, 2024 06:49
@c3y1huang c3y1huang requested review from derekbit and a team September 20, 2024 06:49
derekbit
derekbit approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@derekbit derekbit merged commit 24cbc38 into longhorn:main Sep 20, 2024
5 checks passed
@c3y1huang c3y1huang deleted the style-go-common-lib-imports branch September 20, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

Assignees

@c3y1huang c3y1huang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c3y1huang @derekbit