refactor: engine consolidates the replica related maps into a single one #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longhorn 9244 Signed-off-by: Shuo Wu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=====================================
Coverage 8.97% 8.98%
=====================================
Files 22 22
Lines 6994 6989 -5
=====================================
Hits 628 628
+ Misses 6287 6282 -5
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| for replicaName := range e.ReplicaAddressMap { | ||
| if e.ReplicaModeMap[replicaName] == types.ModeERR { | ||
| for replicaName, replicaStatus := range e.ReplicaStatusMap { | ||
| if replicaStatus.Mode != types.ModeRW && replicaStatus.Mode != types.ModeWO { |
There was a problem hiding this comment.
Slight logic change here in the case that Mode is unset and is "". But perhaps better, because it will be skipped, just as for ModeERR.
…aAdd start Otherwise, the above e.checkAndUpdateInfoFromReplicaNoLock() call will fail the rebuilding replica Signed-off-by: Shuo Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9244
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context