Make this compatible with compakt circuits

[tamj0rd2]

No description provided.

[SunSerega]

Suggested change

	if not remote.interfaces["compaktcircuit"] or not remote.interfaces["compaktcircuit"]["add_combinator"] then
	if not script.active_mods["compaktcircuit"] then

I think it's better if this code errors out when compaktcircuit is active, but it hasn't defined this interface yet.
Otherwise, we might have hard-to-debug cases where everything looks like it loaded fine, but then placing the combinator in the processor doesn't work.

[SunSerega]

And, well, I think check using script.active_mods is easier and more intuitive...

[SunSerega]

Just tried in my save... And seems like the recipe combinator parameters are reset when it's packed. Ig something has been changed on the crafting combinator's side.

[SunSerega]

Ok, packing works if settings are set like this:

				_M.create(packed_input, {crafting_combinator_data={settings=info.settings}})

However, now the settings are reset when unpacking.

You don't implement create_entity, so it's probably a bug in one of the 2 mods...
One thing that might be related is that if I take a blueprint where RC has settings, and try pasting it over an already-built RC with default (or any other) settings - the settings aren't changed.
Actually, this is the problem with many mods. Including processors of compaktcircuit...

[SunSerega]

Ah and also the outline of RC is still shown when hovering over a power pole nearby:

It isn't the case with vanilla combinators, so can definitely be fixed too...

[tamj0rd2]

I've not been playing factorio much recently so most likely won't contribute to this PR again. Feel free to close it if you want.

…

-------- Original Message --------

On 09/06/2024 16:33, Sun Serega wrote: Ah and also the outline of RC is still shown when hovering over a power pole nearby: [image.png (view on web)](https://github.com/loneguardian/CraftingCombinator/assets/27270190/6b57e5f0-1821-4235-b2df-fb6bae3db0da) It isn't the case with vanilla combinators, so can definitely be fixed too... — Reply to this email directly, [view it on GitHub](#3 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AE434JMW4Y5UURUYGWCSFDLZGRYWDAVCNFSM6AAAAABJA4JLCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGY2TMOJTGQ). You are receiving this because you authored the thread.Message ID: ***@***.***>