Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] update release workflow layer name #7

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

8naama
Copy link

@8naama 8naama commented Jan 14, 2025

  • Align the release layer name to match the layer name we provide in the release description
  • Ensure the layer version is updated consistently
    • This change assumes that all layers versions in all regions are the same.
    • The reason for this, is that the current setup uses a general layer-publish.yaml workflow for all layers. This workflow is where we get the new layer version. However, the text in the release notes is only updated for the collector layer.
    • So in order to pass the layer version from layer-publish.yaml workflow >> release-layer-collector.yaml workflow, we generate a single artifact with one of the versions, this is the version we update at the release description.

Future considerations:
In the future, if additional regions are added, we should change this workaround to a more stable solution.
Perhaps generating a text that works for any layer and potentially include a table with the relevant ARN per region, similar to other solutions we have.

@8naama 8naama requested a review from bardabun January 14, 2025 10:18
@8naama 8naama force-pushed the ci/fix-release-layer-name branch from cc98997 to e8f6a55 Compare January 14, 2025 13:10
@8naama 8naama force-pushed the ci/fix-release-layer-name branch from e8f6a55 to 1c63290 Compare January 14, 2025 13:14
Copy link

@bardabun bardabun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

68747470733a2f2f6d65646961312e67697068792e636f6d2f6d656469612f4e4576507a5a386264315634592f67697068792e676966

@8naama 8naama merged commit 9e25636 into main Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants