Improve Trivy explanation on default metrics #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for deluxe-empanada-3ebf3b ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Simplychee
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the
trivy-operatorchart is generating a metrics endpoint.So, although the Logzio trivy integration is designed for Logs data only, if the chart is run alongside the Logzio telemetry chart, these metrics would be collected (since it collects metrics from the entire cluster).
Since Logzio has built in content for these trivy metrics, it wouldn't make sense to ignore them.
Therefore, updated the explanation of sending them.