Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove polyfill and fix encoding issue #27

Merged
merged 1 commit into from
May 21, 2024
Merged

refactor!: remove polyfill and fix encoding issue #27

merged 1 commit into from
May 21, 2024

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented May 20, 2024 •
edited
Loading

Summary

fixes #21 #24

  • remove polyfill since the new version of react-native has native implementation
  • use TextEncoder to avoid base64 malformation issue

Testing

  • local tested iOS
  • local tested web

@gao-sun gao-sun changed the title refactor!: fix encoding issue refactor!: remove polyfill and fix encoding issue May 20, 2024
@gao-sun gao-sun requested review from simeng-li and a team May 20, 2024 13:43
@gao-sun gao-sun marked this pull request as ready for review May 20, 2024 13:43
Base automatically changed from gao-bump-deps to master May 21, 2024 03:13
@gao-sun gao-sun enabled auto-merge (squash) May 21, 2024 03:13
@gao-sun gao-sun merged commit 08abea3 into master May 21, 2024
4 checks passed
@gao-sun gao-sun deleted the gao-fix-encoding-issue branch May 21, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charIeszhao charIeszhao charIeszhao approved these changes

@simeng-li simeng-li Awaiting requested review from simeng-li

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gao-sun @charIeszhao