feat(core): initial implementation of user set mfa secrets / codes #6654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atarbalouti
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/routes/admin-user/mfa-verification.openapi.json | 📈 +1.14 KB |
| packages/core/src/routes/admin-user/mfa-verifications.test.ts | 📈 +2.33 KB |
| packages/core/src/routes/admin-user/mfa-verifications.ts | 📈 +784 Bytes |
| packages/core/src/routes/interaction/utils/backup-code-validation.ts | 📈 +198 Bytes |
| packages/core/src/routes/interaction/utils/totp-validation.test.ts | 📈 +306 Bytes |
| packages/core/src/routes/interaction/utils/totp-validation.ts | 📈 +255 Bytes |
| packages/phrases/src/locales/en/errors/user.ts | 📈 +118 Bytes |
|
Hi @atarbalouti , the secrets and backup codes are randomly generated, so it doesn’t seem necessary for the user to confirm them beforehand. The process could be streamlined by directly creating the codes, and then giving users the option to view or print them once they’re generated. |
|
Hi @atarbalouti , after discussion, this is indeed an secenario that can be optimized, and we are taking a look. cc @wangsijie |
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
I'll handle this next week. |
wangsijie
force-pushed
the
feat-user-initiated-mfa
branch
from
47e19bb
to
c5fa75b
Compare
wangsijie
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the possibility to add user set mfa secrets (TOTP / backup codes). This is necessary for the creation of such secrets directly in the application, because the user has first to confirm the answer or that he printed the backup codes before really creating them in Logto.
Testing
Manually by creating a TOTP secret.
Checklist
.changeset