Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

feat(tencent-mail): add tencent mail connector #47

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(tencent-mail): add tencent mail connector #47

wants to merge 6 commits into from

Conversation

StringKe
Copy link
Contributor

Summary

https://cloud.tencent.com/product/ses

Testing

local test, send mail suucess

@StringKe StringKe mentioned this pull request Dec 19, 2022
Open
@charIeszhao charIeszhao changed the title feat(tencent-mail): add tenecent mail connector feat(tencent-mail): add tencent mail connector Dec 20, 2022
charIeszhao
charIeszhao approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@charIeszhao charIeszhao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Edit: hold on...

charIeszhao
charIeszhao suggested changes Dec 20, 2022
View reviewed changes
Copy link
Member

@charIeszhao charIeszhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments, and let me know if you need any further discussion. Thanks!

@charIeszhao charIeszhao force-pushed the tencent-email branch 2 times, most recently from 7280f72 to 9fc6091 Compare December 21, 2022 08:40
wangsijie
wangsijie reviewed Dec 29, 2022
View reviewed changes
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind rebase master and update project structure? You can see other packages, the main change is package.extend.json. And if you need help, just call it out, our team can do this for you.

wangsijie
wangsijie approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, what we need is only a README

wangsijie
wangsijie reviewed Dec 30, 2022
View reviewed changes
Copy link
Contributor

@wangsijie wangsijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But CI checks failed, seems like lock problem.

darcyYe
darcyYe approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@darcyYe darcyYe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/connector-tencent-email/src/http.ts Outdated Show resolved Hide resolved
@charIeszhao
fix: signature issue
efe520c 
Co-Authored-By: Charles Zhao <[email protected]>
@charIeszhao
chore: update README
0b85ea5 
Co-Authored-By: Charles Zhao <[email protected]>
@gao-sun
Copy link
Member

gao-sun commented Apr 3, 2023

thanks for contributing @StringKe. we're going to archive this repo in favor of the connectors directory in the Logto monorepo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charIeszhao charIeszhao charIeszhao requested changes

@wangsijie wangsijie wangsijie approved these changes

@darcyYe darcyYe darcyYe approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StringKe @gao-sun @wangsijie @charIeszhao @darcyYe