This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
refactor: elaborate connector error messages #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
force-pushed
the
yemq-log-4881-expose-connector-error-details
branch
from
bab33b7
to
dfdf63c
Compare
gao-sun
reviewed
Mar 18, 2023
| @@ -148,7 +150,7 @@ describe('Facebook connector', () => { | |||
| set: jest.fn(), | |||
| get: jest.fn(), | |||
| }) | |||
| ).rejects.toMatchError(new ConnectorError(ConnectorErrorCodes.SocialAccessTokenInvalid)); | |||
| ).rejects.toMatchError(new ConnectorError(ConnectorErrorCodes.General, JSON.stringify(''))); | |||
There was a problem hiding this comment.
why do we need manually stringify here?
| @@ -126,7 +126,7 @@ describe('getUserInfo', () => { | |||
| const connector = await createConnector({ getConfig }); | |||
| await expect( | |||
| connector.getUserInfo({ code: 'code' }, jest.fn(), { set: jest.fn(), get: jest.fn() }) | |||
| ).rejects.toMatchError(new ConnectorError(ConnectorErrorCodes.SocialAccessTokenInvalid)); | |||
| ).rejects.toMatchError(new ConnectorError(ConnectorErrorCodes.General, JSON.stringify(''))); | |||
Comment on lines
83
to
86
| assert( | ||
| accessToken, | ||
| new ConnectorError(ConnectorErrorCodes.SocialAuthCodeInvalid, 'accessToken is missing.') | ||
| ); |
There was a problem hiding this comment.
actually the access token logic is very repetitive as far as i can see. should be extracted into a function?
There was a problem hiding this comment.
Yes, this check is necessary for almost all social connectors. We can extract to @logto/connector-kit and seems it is not a blocker of GA.
darcyYe
force-pushed
the
yemq-log-4881-expose-connector-error-details
branch
3 times, most recently
from
300b075
to
ef9f1c4
Compare
darcyYe
force-pushed
the
yemq-log-4881-expose-connector-error-details
branch
from
ef9f1c4
to
241ed48
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
elaborate connector error messages
Testing
UTs.
Checklist
.changset-stagedOR