Switch from push mode to pull #485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jsvd
reviewed
Nov 7, 2023
| @@ -134,6 +134,7 @@ public void initChannel(SocketChannel socket){ | |||
| new IdleStateHandler(localClientInactivityTimeoutSeconds, IDLESTATE_WRITER_IDLE_TIME_SECONDS, localClientInactivityTimeoutSeconds)); | |||
| pipeline.addLast(BEATS_ACKER, new AckEncoder()); | |||
| pipeline.addLast(CONNECTION_HANDLER, new ConnectionHandler()); | |||
| pipeline.addLast(new FlowLimiterHandler()); | |||
There was a problem hiding this comment.
Do we have a reason why this is placed in this location of the pipeline? would it make sense to be first instead? Or right after the ssl handler?
There was a problem hiding this comment.
Moved in the same position it was from the originating PR #475, but your point is correct. It should be the first handler in the Netty pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
To control spikes of memory usage, the incoming message reads switched from push mode to pull, so that the plugin has control on rate of ingestion and it's not the determined by the clients.
What does this PR do?
Changes the way the plugin pulls data and handle incoming connections to avoid many clients pushing more data than what it can handle.
Switches to pull read instead of push read. Instead to respond to every buffer that a connection present, it's the plugin that actively grab the byte buffer to process.
This work is based on the existing #410 #475.
Why is it important/What is the impact to the user?
Provides a counter measure to avoid that clients decide on the memory of the local process, pushing more and more data also if the process can't cope with the flow rate of allocations.
Checklist
Author's Checklist