Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include http status code in metadata #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaauie
Copy link

@yaauie yaauie commented Aug 1, 2022

Release notes

The HTTP status code for each request is now included in the response metadata.

What does this PR do?

Adds HTTP status code of response

Why is it important/What is the impact to the user?

Adds HTTP status code of response, so that a pipeline can differentiate between the semantics of different error status codes. For example, in some contexts a 404 (Not Found) is substantially different than a 400 (Bad Request), and it may be helpful for downstream plugins in a pipeline to handle the two cases separately.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@yaauie yaauie added the enhancement New feature or request label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Filter Plugin - Request/Response Metadata
2 participants