-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MaxMind GeoIP2 Enterprise and Anonymous-IP databases #223
Add support for MaxMind GeoIP2 Enterprise and Anonymous-IP databases #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woohoo! A lot good stuffs in this PR. Thanks for adding test databases 🎉 , fixing the missing close() and updating many legacy parts in this plugin.
My comments are all minor about log and naming. The two new databases run as expected
29426f0
to
5b1a400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM. good catch on supporting jvm 8.
bb6a48e
to
9eac8ed
Compare
VERSION
file.Closes: #153
Closes: #212