Support to exclude fields from concatenate_all_fields
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider this example:
```JSON
{
"@timestamp": "2023-05-23T23:23:23.555Z",
"@Version": "1",
"beat": {
"hostname": "gnu.example.com",
"name": "gnu.example.com",
"version": "5.2.2"
},
"host": "gnu.example.com"
}
```
Using this filter:
```Logstash
fingerprint {
concatenate_all_fields => true
target => "[@metadata][_id]"
method => "SHA512"
key => "XXX"
base64encode => true
}
```
Here, the order of the `.beat` hash is non-deterministic and the plugin
did not do a deep sort as part of the serialization. This resulted in
different fingerprints for the same event because the order of the three
keys (hostname, name, version) changed randomly in the serialization.
This has been fixed by recursively checking for hashes and serializing
them in sorted order.
Note that this changes the serialization format and thus breaks
backwards compatibility. The old format could be emulated in order to
not break backwards compatibility. Backwards compatibility in this case
means to generate the same fingerprint for the same input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Feature complete. Need to rebase and fix/add unit tests ontop of #41.
This implements #43
I plan to rebase when #41 is merged because I developed those two features in a row as I needed them for our environment. Feel free to review this already: 42e8f23