fix(StakeManager): add checks for whether lockup period is in range #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3esmit
approved these changes
Nov 1, 2023
0x-r4bbit
force-pushed
the
feat/vault-factory
branch
from
d6244ab to
8e2b9f1
Compare
This commit introduces `MIN_LOCKUP_PERIOD` and `MAX_LOCKUP_PERIOD` and makes use of them within `StakeManager.stake()` and `StakeManager.lock()` accordingly. When users deposit tokens into their vault via `stake()`, they can provide an optional lockup time. If the value is `0` it implies users do not want to lock their stake. If the value is `> 0` it has to be within the range of `MIN_LOCKUP_PERIOD` and `MAX_LOCKUP_PERIOD`. Properly addresses #15
0x-r4bbit
force-pushed
the
feat/lockup-period
branch
from
532c90d to
db74969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
MIN_LOCKUP_PERIODandMAX_LOCKUP_PERIODand makes use of them withinStakeManager.stake()andStakeManager.lock()accordingly.When users deposit tokens into their vault via
stake(), they can provide an optional lockup time. If the value is0it implies users do not want to lock their stake.If the value is
> 0it has to be within the range ofMIN_LOCKUP_PERIODandMAX_LOCKUP_PERIOD.Properly addresses #15
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?