Stake Relativization Specification + Fixes #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidrusu
changed the title
…otal-stake-inference
davidrusu
changed the title
zeegomo
approved these changes
Mar 21, 2024
| self.local_chain = new_chain | ||
| if new_chain != self.local_chain: | ||
| self.forks.remove(new_chain) | ||
| self.forks.append(self.local_chain) |
zeegomo
reviewed
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thrust of this PR is implementing Stake Relativization, but in doing so, a few issues with the orphan handling and fork management code came up and so this PR has gotten a bit more complex with the various fixes.
Unfortunately the bugs were revealed after I had done the majority of the stake relativization implementation otherwise I would have split them out into smaller PR's.
notable bugs:
I've updated the specification in Notion from learnings having gone through the implementation process, namely the inference period is no longer the entire epoch, we need a stable value for total stake for when we enter the next epoch:
https://www.notion.so/Stake-Relativization-65f5ed5522b64c36b625652023318d88?pvs=4#6e3c4d567eda49079822662075b847ed