Added verification to certificate #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacv
approved these changes
Mar 14, 2024
typo short -> sort Co-authored-by: gusto <[email protected]>
megonen
reviewed
Mar 14, 2024
There was a problem hiding this comment.
to prevent Rogue Key Attack mentioned here https://www.notion.so/BLS-Aggregated-and-Threshold-Signature-5a37ed1db01e4f9594080e1e6a5ef5f4, test can be added for PoP (proof of possesion) mechanism
davidrusu
reviewed
Mar 15, 2024
danielSanchezQ
force-pushed
the
certificate-verification
branch
from
2ccae7f to
8fa0f8a
Compare
danielSanchezQ
commented
Mar 15, 2024
Comment on lines
+58
to
+67
| def verify(self, nodes_public_keys: List[BLSPublickey]) -> bool: | ||
| """ | ||
| List of nodes public keys should be a trusted list of verified proof of possession keys. | ||
| Otherwise, we could fall under the Rogue Key Attack | ||
| `assert all(bls_pop.PopVerify(pk, proof) for pk, proof in zip(node_public_keys, pops))` | ||
| """ | ||
| # we sort them as the signers bitfield is sorted by the public keys as well | ||
| signers_keys = list(compress(sorted(nodes_public_keys), self.signers)) | ||
| message = build_attestation_message(self.aggregated_column_commitment, self.row_commitments) | ||
| return bls_pop.AggregateVerify(signers_keys, [message]*len(signers_keys), self.aggregated_signatures) |
There was a problem hiding this comment.
@davidrusu I added this comment. This keys verification should be done upon registration.
@megonen We have to update the specification documents with this most probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.