Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted release kinds by filename to fix test. #32

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

witx98
Copy link
Member

@witx98 witx98 commented Jan 15, 2025

The test was failing due to unpredictable ordering of release kinds. Added sorting by filename to ensure consistent test results. This change improves test stability and reliability.

@marwin1991

@witx98 witx98 requested a review from marwin1991 January 15, 2025 23:11
@witx98 witx98 self-assigned this Jan 15, 2025
@witx98
Copy link
Member Author

witx98 commented Jan 15, 2025

On another note, is this CI/CD configuration correct? Should the tests be run twice? @marwin1991

Comment on lines +3 to +7
on:
push:
branches: [ master ]
pull_request:
branches: [ master ]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it to this

@marwin1991 marwin1991 merged commit 06b9536 into master Jan 16, 2025
3 checks passed
@marwin1991 marwin1991 deleted the test-fix branch January 16, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants