Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Update lambda response processing #258

Merged
merged 3 commits into from
May 17, 2024
Merged

Bugfix: Update lambda response processing #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbb5a72
Use another method to capture/parse response from lambda invocation.
Apr 29, 2024
b59d741
Syntax fix.
Apr 29, 2024
ee23521
Fix tests.
May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,13 +482,10 @@ class ServerlessWSGI {
// remotely, we get a string back and we want it to appear in the console as it would have
// if it was invoked locally.
//
// Thus, console.log is temporarily hijacked to capture the output and parse it as JSON. This
// hack is needed to avoid having to call the provider-specific invoke plugins.
// We capture stdout output in order to parse the array returned from the lambda invocation,
// then restore stdout.
let output = "";

/* eslint-disable no-console */
const native_log = console.log;
console.log = (msg) => (output += msg + "\n");
/* eslint-disable no-unused-vars */
const {
originalStdoutWrite, // Original `write` bound to `process.stdout`#noqa
Expand All @@ -500,9 +497,7 @@ class ServerlessWSGI {
orig, // data input
originalStdoutWrite // // Original `write` bound to `process.stdout`
) => {
// Example of filtering ANSI codes for original stdout.write
originalStdoutWrite(orig.replace(/["]+/g, "").replace(/\\n/g, "\n"));
// originalStdoutWrite(orig.substring(orig.indexOf(",") + 7).replace(/\\n/g,"\n") + "\n");
output += orig;
}
);
/* eslint-enable no-unused-vars */
Expand All @@ -525,18 +520,18 @@ class ServerlessWSGI {
? _.trimEnd(output[1], "\n")
: output[1];
if (return_code == 0) {
native_log(output_data);
this.serverless.cli.log(output_data);
} else {
return reject(output_data);
return reject(new this.serverless.classes.Error(output_data));
}
} else {
native_log(output);
this.serverless.cli.log(output);
}
return resolve();
})
)
.finally(() => {
console.log = native_log;
restoreStdoutWrite();
});
/* eslint-enable no-console */
}
Expand Down
Loading
Loading