test: http helpers (#18)

* test: http helpers

* test: add test for respond with json through generic interface

* test: adding test for error response

handlers.go

@@ -5,7 +5,6 @@ import (
 	"database/sql"
 	"encoding/hex"
 	"encoding/json"
-	"fmt"
 	"log"
 	"net/http"
 	"net/mail"
@@ -260,7 +259,6 @@ func (apiCfg *apiConfig) postAPIUsers(w http.ResponseWriter, r *http.Request) {
 	_, err = mail.ParseAddress(payload.Email)
 
 	if err != nil {
-		fmt.Println(err)
 		respondWithError(w, http.StatusBadRequest, "invalid email address")
 		return
 	}

httphelper_test.go

@@ -0,0 +1,56 @@
+package main
+
+import (
+	"encoding/json"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+)
+
+func TestRespondWithJSON(t *testing.T) {
+	t.Run("test respond with json with generic interface", func(t *testing.T) {
+		response := httptest.NewRecorder()
+
+		type FooStruct struct {
+			Foo string `json:"foo"`
+		}
+
+		testStruct := FooStruct{
+			Foo: "bar",
+		}
+
+		respondWithJSON(response, http.StatusOK, testStruct)
+
+		wantStruct := FooStruct{}
+
+		err := json.NewDecoder(response.Body).Decode(&wantStruct)
+
+		if err != nil {
+			t.Errorf("could not parse result as expected")
+		}
+
+		if testStruct != wantStruct {
+			t.Errorf("failed to respond with arbitrary interface got %q want %q", testStruct, wantStruct)
+		}
+	})
+}
+
+func TestRespondWithError(t *testing.T) {
+	t.Run("test respond with error with generic error", func(t *testing.T) {
+		response := httptest.NewRecorder()
+
+		respondWithError(response, http.StatusInternalServerError, "stuff is broken")
+
+		wantStruct := errorResponse{}
+
+		err := json.NewDecoder(response.Body).Decode(&wantStruct)
+
+		if err != nil {
+			t.Errorf("could not parse result as expected")
+		}
+
+		if wantStruct.Error != "stuff is broken" {
+			t.Errorf("failed to respond with a generic error")
+		}
+	})
+}