-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust title headings #442
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nebelsprachen I had to approve/trigger the vale
workflow (it needs to be done for all external contributors). As you can see, there are some vale
rules violations. Could you please fix those? Please refer to the CONTRIBUTING.md to learn more about styling guidelines and working with vale.
Tip
you can find the exact rules violations in the Files changed
tab
Thank you, @Piotr1215. I addressed some of the linter comments, but others seem more like suggestions rather than strict rules and may not be entirely correct. For example, one rule states that "admin" should not be capitalized, but in the given example, the text references a UI element, where capitalization seems be appropriate. Another rule suggests using "the platform" instead of "the vCluster Platform," but this change could make the text ambiguous, especially for new users who may not be familiar with the product. Also, mentioned in the comment above "platform" is formatted inconsistently throughout the docs. I am not sure if it is a proper noun, as in "the vCluster Platform" or if we are just referring to it as "the platform". Lastly, sentence case headings are not used throughout the doc. Some of the pages use title case for the first level headings, and some other pages use title case for second level headings, or a mix of the two. The sidebar heading are in title case. I tried to resolve some of the lint issues, but could not make the linter entirely happy. |
Vale rules overrideIn the case of Product namingThe product naming should be Note add the above to the style guidelines Inconsistent formattingNot all documents were changed since I've introduced |
Content Description
Some of the titles use a mix of title case and sentence case. Since we are treating "Platform" as a proper noun, I left it capitalized. However, other terms like "integration" or "configuration" are not proper nouns, so they should likely be in lowercase to align with sentence case style.
Slight rewrite to text and added commas for clarity
Preview Link
Internal Reference
n/a