fix: FindDevContainer tries to lookup the pod and returns first result #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janekbaraniewski
approved these changes
Jan 28, 2025
pascalbreuninger
force-pushed
the
fix/find-pod-immediate
branch
from
4a3f358 to
e7449ad
Compare
So far we were waiting for the pod to come up in the implementation of the `FindDevContainer` interface. This leads to a state where users would have to wait for up to `options.PodTimeout` to delete a workspace when the pod is stuck in an unschedulable/otherwise pending state. `FindDevContainer` now behaves similar to implementations in the dockerDriver in that it just looks up the pod and reports a result immediately
pascalbreuninger
force-pushed
the
fix/find-pod-immediate
branch
from
e7449ad to
8fc4ea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we were waiting for the pod to come up in the implementation of
the
FindDevContainerinterface. This leads to a state where userswould have to wait for up to
options.PodTimeoutto delete a workspacewhen the pod is stuck in an unschedulable/otherwise pending state.
FindDevContainernow behaves similar to implementations in thedockerDriver in that it just looks up the pod and reports a result
immediately