Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report name #2947

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Report name #2947

wants to merge 4 commits into from

Conversation

obriat
Copy link

@obriat obriat commented Oct 20, 2024

  • Add host, start time and scenario name to report filename (should be easier to find and sort)
  • Add human friendly duration in html report
  • Add some doc about dev and debugging

Close #2931

@obriat obriat changed the title Report name Report name (#2931) Oct 20, 2024
@obriat obriat changed the title Report name (#2931) Report name Oct 20, 2024
@cyberw
Copy link
Collaborator

cyberw commented Oct 21, 2024

Can you do this without adding the humanfriendly dependency? Seems a bit much to add an entire package just to format one date...

There's already some info about debugging in running-in-debugger.rst, can you maybe add your info there instead (and link to it from developing-locust.rst)

@andrewbaldwin44 Any opinions on the TS stuff?

@andrewbaldwin44
Copy link
Collaborator

@obriat Could you also check that this works with the --html flag?

@obriat
Copy link
Author

obriat commented Oct 21, 2024

Can you do this without adding the humanfriendly dependency? Seems a bit much to add an entire package just to format one date...

I'm not a Python expert, but does this package adds a overhead to the runners or just the report part?

There's already some info about debugging in running-in-debugger.rst, can you maybe add your info there instead (and link to it from developing-locust.rst)

I'll move my doc to this page

@JavierUhagon
Copy link
Contributor

JavierUhagon commented Oct 21, 2024

I'm not a Python expert, but does this package adds a overhead to the runners or just the report part?

Hey there! Not a mantainer, but, I don't think the issue is adding a overhead, it's having to add a full package (that hasn't been updated since 2020) just to format a date for a report, I'd say that adding your own implementation would be better :)

You can always check how humanfriendly does it!
https://github.com/xolox/python-humanfriendly/blob/6758ac61f906cd8528682003070a57febe4ad3cf/humanfriendly/__init__.py#L402

It really isn't hard nor long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading report should provide a meaningful human name
4 participants