Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated validator to 0.19 #993

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

DenuxPlays
Copy link
Contributor

@DenuxPlays DenuxPlays commented Nov 18, 2024

Updated validator to 0.19 and all Cargo.lock files where needed.

Closes: #992

@jondot
Copy link
Contributor

jondot commented Nov 20, 2024

@DenuxPlays thanks for this!
Can you please update in here instead? https://github.com/loco-rs/loco/tree/master/loco-new/base_template

this is the new way starters are made

@DenuxPlays
Copy link
Contributor Author

@DenuxPlays thanks for this! Can you please update in here instead? https://github.com/loco-rs/loco/tree/master/loco-new/base_template

this is the new way starters are made

Should I revert the changs I made to the other starters?

@kaplanelad
Copy link
Contributor

@DenuxPlays yes, revet the starters to the new path

@DenuxPlays
Copy link
Contributor Author

@DenuxPlays yes, revet the starters to the new path

Done!

Reverted old changes and updated the base template.

@DenuxPlays
Copy link
Contributor Author

@kaplanelad I am also working on a pr to update all outdated dependencies.

Is this something you would accept?

@kaplanelad
Copy link
Contributor

Hey @DenuxPlays,
Thank you for your willingness to contribute!
Updating dependencies is indeed a good practice to keep the project secure and up-to-date.

However, when proposing updates, there are a few key considerations to keep in mind:

  1. Package size: Ensure that the size increase (if any) is reasonable and won't negatively impact performance.
  2. Changelog and breaking changes: Review the changelogs for any breaking changes or important updates that might require adjustments in the codebase.
  3. Feature flags: Check if any new feature flags have been added or enabled by default, and verify whether they align with the project's current requirements.

We carefully choose our dependencies to maintain a balance between functionality, performance, and maintainability. To help with the review process, it would be great if your PR includes:

A summary of the changes introduced by the updated dependencies.
Any potential impact these updates might have on the project.

@DenuxPlays
Copy link
Contributor Author

Hey @kaplanelad

Package size and performance is not affected by this update.

The validator crate hasn't change lot of things.
I think the main "breaking" change was the bump of the msrv to 1.81
Full changelog can be found here:
https://github.com/Keats/validator/blob/master/CHANGELOG.md#0190-20241103

It's just a very basic dependecy update.

Also I have noticed a few outdated dependencies.
Have you considered using a bot like renovate or dependabot to automate this process?

@DenuxPlays
Copy link
Contributor Author

Hopefully fixed all tests 👍

@DenuxPlays
Copy link
Contributor Author

@kaplanelad
CI Failures are unrelated to my change.
Should I fix them?

@kaplanelad
Copy link
Contributor

Fixed the issues, and the CI on the master branch is now passing.

@kaplanelad kaplanelad merged commit a103c1c into loco-rs:master Dec 2, 2024
12 checks passed
@DenuxPlays DenuxPlays deleted the chore/validator-0-19 branch December 7, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update validator crate to 0.19
3 participants