-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated validator to 0.19
#993
Conversation
@DenuxPlays thanks for this! this is the new way starters are made |
Should I revert the changs I made to the other starters? |
@DenuxPlays yes, revet the starters to the new path |
263cecc
to
63bca82
Compare
Done! Reverted old changes and updated the base template. |
@kaplanelad I am also working on a pr to update all outdated dependencies. Is this something you would accept? |
63bca82
to
28297b2
Compare
Hey @DenuxPlays, However, when proposing updates, there are a few key considerations to keep in mind:
We carefully choose our dependencies to maintain a balance between functionality, performance, and maintainability. To help with the review process, it would be great if your PR includes: A summary of the changes introduced by the updated dependencies. |
28297b2
to
1d74e0c
Compare
1d74e0c
to
8d97b04
Compare
8d97b04
to
2dc2eee
Compare
Hey @kaplanelad Package size and performance is not affected by this update. The validator crate hasn't change lot of things. It's just a very basic dependecy update. Also I have noticed a few outdated dependencies. |
Hopefully fixed all tests 👍 |
@kaplanelad |
Fixed the issues, and the CI on the master branch is now passing. |
Updated validator to
0.19
and allCargo.lock
files where needed.Closes: #992