-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Updated validator to 0.20
#1199
Open
DenuxPlays
wants to merge
4
commits into
loco-rs:master
Choose a base branch
from
DenuxPlays:chore/update-validator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenuxPlays
force-pushed
the
chore/update-validator
branch
from
January 20, 2025 13:43
f1f8ab7
to
e0dd1b7
Compare
DenuxPlays
changed the title
[BREAKING] Updated validator
[BREAKING] Updated validator to Jan 20, 2025
0.20
Going to fix ci later |
DenuxPlays
force-pushed
the
chore/update-validator
branch
from
January 20, 2025 16:27
e0dd1b7
to
0c57af7
Compare
1 task
working now |
DenuxPlays
force-pushed
the
chore/update-validator
branch
from
January 21, 2025 06:41
0c57af7
to
2121480
Compare
can you fix the ci? |
Yeah later today or this week when I have time |
DenuxPlays
force-pushed
the
chore/update-validator
branch
from
January 23, 2025 16:35
2121480
to
ed2dcb8
Compare
…re/update-validator
Fixed the fixable ci if the windows test finish sometimes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With validator 0.20 non
'static
str can be used inValidationErrors
because it now usesCow<'static, str>
.A nice thing to have now.
I haven't opened an issue so if this isn't wanted just close it.