Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify external directories for sources #1

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

umireon
Copy link
Member

@umireon umireon commented Feb 4, 2024

This change is required for locaal-ai/obs-ocr#12 and should be merged first.

@umireon
Copy link
Member Author

umireon commented Feb 4, 2024

@royshil

@umireon umireon requested a review from royshil February 4, 2024 20:27
Copy link
Contributor

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM
however doesn't this requre changing the build.yaml file as well?
it seems to build fine..

@umireon
Copy link
Member Author

umireon commented Feb 4, 2024

@royshil I suppose the old implementation of build-linux.sh is broken but it has happened to work.

@umireon
Copy link
Member Author

umireon commented Feb 4, 2024

TESSERACT_DIR and LEPTONICA_DIR have default values so that the workflows don't need to be changed.

@umireon umireon merged commit eedf1aa into locaal-ai:main Feb 4, 2024
7 checks passed
@umireon umireon deleted the umireon/build-with-upstream-tar branch February 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants