🐛 fix: Fix Chart in React 19

lobehub · Jan 7, 2025 · c248945 · c248945
1 parent 53f0598
commit c248945
Show file tree

Hide file tree

Showing 11 changed files with 5 additions and 18 deletions.
diff --git a/src/AreaChart/demos/index.tsx b/src/AreaChart/demos/index.tsx
@@ -78,7 +78,6 @@ export default () => {
         value: 900,
       },
       autoMinValue: false,
-      barCategoryGap: 10,
       connectNulls: false,
       enableLegendSlider: false,
       intervalType: {

diff --git a/src/AreaChart/index.tsx b/src/AreaChart/index.tsx
@@ -84,7 +84,7 @@ const AreaChart = forwardRef<HTMLDivElement, AreaChartProps>((props, ref) => {
     xAxisLabel,
     yAxisLabel,
     width = '100%',
-    height = '20rem',
+    height = 280,
     style,
     customCategories,
     ...rest
@@ -188,7 +188,6 @@ const AreaChart = forwardRef<HTMLDivElement, AreaChartProps>((props, ref) => {
               dataKey={index}
               dy={rotateLabelX?.verticalShift}
               fill=""
-              height={rotateLabelX?.xAxisHeight}
               hide={!showXAxis}
               interval={startEndOnly ? 'preserveStartEnd' : intervalType}
               minTickGap={tickGap}

diff --git a/src/BarChart/demos/example.tsx b/src/BarChart/demos/example.tsx
@@ -41,7 +41,6 @@ export default () => {
       <h4>Number of species threatened with extinction (2021)</h4>
       <BarChart
         categories={['Number of threatened species']}
-        className="mt-6"
         data={data}
         index="name"
         valueFormatter={valueFormatter}

diff --git a/src/BarChart/demos/index.tsx b/src/BarChart/demos/index.tsx
@@ -55,7 +55,6 @@ export default () => {
       },
       maxValue: 1000,
       minValue: 0,
-      relative: false,
       showAnimation: false,
       showGridLines: true,
       showLegend: true,

diff --git a/src/BarChart/index.tsx b/src/BarChart/index.tsx
@@ -76,7 +76,7 @@ const BarChart = forwardRef<HTMLDivElement, BarChartProps>((props, ref) => {
     yAxisLabel,
     className,
     width = '100%',
-    height = '20rem',
+    height = 280,
     style,
     ...rest
   } = props;
@@ -183,7 +183,6 @@ const BarChart = forwardRef<HTMLDivElement, BarChartProps>((props, ref) => {
                 domain={yAxisDomain as AxisDomain}
                 dy={rotateLabelX?.verticalShift}
                 fill=""
-                height={rotateLabelX?.xAxisHeight}
                 hide={!showXAxis}
                 minTickGap={tickGap}
                 stroke=""
@@ -215,7 +214,6 @@ const BarChart = forwardRef<HTMLDivElement, BarChartProps>((props, ref) => {
                 dataKey={index}
                 dy={rotateLabelX?.verticalShift}
                 fill=""
-                height={rotateLabelX?.xAxisHeight}
                 hide={!showXAxis}
                 interval={startEndOnly ? 'preserveStartEnd' : intervalType}
                 minTickGap={tickGap}

diff --git a/src/FunnelChart/demos/index.tsx b/src/FunnelChart/demos/index.tsx
@@ -16,12 +16,10 @@ export default () => {
   const props: FunnelChartProps | any = useControls(
     {
       barGap: '20%',
-      enableLegendSlider: false,
       evolutionGradient: true,
       gradient: false,
       showArrow: true,
       showGridLines: true,
-      showLegend: true,
       showTooltip: true,
       showXAxis: true,
       showYAxis: true,

diff --git a/src/FunnelChart/index.tsx b/src/FunnelChart/index.tsx
@@ -115,7 +115,7 @@ const FunnelChart = forwardRef<HTMLDivElement, FunnelChartProps>((props, ref) =>
     barGap = '20%',
     loading,
     width = '100%',
-    height = '20rem',
+    height = 280,
     className,
     style,
     yAxisWidth,

diff --git a/src/LineChart/demos/index.tsx b/src/LineChart/demos/index.tsx
@@ -78,7 +78,6 @@ export default () => {
         value: 900,
       },
       autoMinValue: false,
-      barCategoryGap: 10,
       connectNulls: false,
       enableLegendSlider: false,
       intervalType: {
@@ -91,7 +90,6 @@ export default () => {
       showTooltip: true,
       showXAxis: true,
       showYAxis: true,
-      stack: false,
       startEndOnly: false,
       tickGap: {
         step: 1,

diff --git a/src/LineChart/index.tsx b/src/LineChart/index.tsx
@@ -78,7 +78,7 @@ const LineChart = forwardRef<HTMLDivElement, LineChartProps>((props, ref) => {
     xAxisLabel,
     yAxisLabel,
     width = '100%',
-    height = '20rem',
+    height = 280,
     style,
     customCategories,
     loading,
@@ -184,7 +184,6 @@ const LineChart = forwardRef<HTMLDivElement, LineChartProps>((props, ref) => {
               dataKey={index}
               dy={rotateLabelX?.verticalShift}
               fill=""
-              height={rotateLabelX?.xAxisHeight}
               hide={!showXAxis}
               interval={startEndOnly ? 'preserveStartEnd' : intervalType}
               minTickGap={tickGap}

diff --git a/src/ScatterChart/demos/index.tsx b/src/ScatterChart/demos/index.tsx
@@ -160,7 +160,6 @@ export default () => {
       showTooltip: true,
       showXAxis: true,
       showYAxis: true,
-      stack: false,
       startEndOnly: false,
       tickGap: {
         step: 1,

diff --git a/src/ScatterChart/index.tsx b/src/ScatterChart/index.tsx
@@ -137,7 +137,7 @@ const ScatterChart = forwardRef<HTMLDivElement, ScatterChartProps>((props, ref)
     xAxisLabel,
     yAxisLabel,
     width = '100%',
-    height = '20rem',
+    height = 280,
     style,
     customCategories,
     ...rest
@@ -243,7 +243,6 @@ const ScatterChart = forwardRef<HTMLDivElement, ScatterChartProps>((props, ref)
                 domain={xAxisDomain as AxisDomain}
                 dy={rotateLabelX?.verticalShift}
                 fill=""
-                height={rotateLabelX?.xAxisHeight}
                 hide={!showXAxis}
                 interval={startEndOnly ? 'preserveStartEnd' : intervalType}
                 minTickGap={tickGap}