Add random image after order creation #619
Conversation
The seller receives an image once an order is created. They will also receive the same image when paying the invoice. This way, they can verify that the invoice originates from the bot. Signed-off-by: ndungudedan <[email protected]>
ndungudedan
force-pushed
the
random_image
branch
from
3cbb207 to
8bee9f5
Compare
|
How do you go about translations? I could probably use Google Translate but it's usually not that good. Please advise. |
Hi @ndungudedan, translations are put in the |
There was a problem hiding this comment.
Hi @ndungudedan, good start, it works!
However, it still does not fully comply with what the issue asks:
- The image must appear in the center of the QR where the invoice is shown.
- The images must be simple, without much content, easily identifiable, preferably with only 1 color.
|
@ndungudedan we can consult @grunch opinion, I was generating some images with chatgpt,. |
|
Hi @ndungudedan the main idea is we should use simple images for the user can easily remember and identify it, let's see an example After seller creates an order seller receives an image, let's say the seller receives a bear
In the message after order creation she sould say "Remember this image because you will see it again inside the invoice to pay" Then when someone takes the order the bot sends an invoice with the image right in the center of the invoice, here an example with a real lnp2pbot invoice
|
|
Here are 71 icons from that same collections open source you can use, I you ask me I would prefer to have something like breez wallet which is more efficient probably, they have some images of animals of one color and then they change the color randomly for avatars, if you want to see it you can try the wallet here, but those icons attached in this comments also work well |
…ons for updated text
|
@grunch Just made a commit with the requested changes. I used your zip of images. Please have a look. |
There was a problem hiding this comment.
Hi @ndungudedan, much better! However, the images are very blurry, and inside the QR it is very small.
Please use the images with higher resolution, inside this zip #619 (comment) those in Animals png large
Also increase the size of the image inside the QR a little so that even with the blurred QR the image can be identified
util/index.ts
Outdated
| const centerImage = new Image(); | ||
| centerImage.src = `data:image/png;base64,${randomImage}`; | ||
|
|
||
| const imageSize = canvas.width * 0.2; |
There was a problem hiding this comment.
I think a more appropriate size might be 0.3
There was a problem hiding this comment.
Set it to 0.3. Looks much better.
|
@ndungudedan Please update the branch with the latest changes from main because some bugs fixed in #620 are reappearing. Thanks! |
|
@Catrya I have replaced the images with the large png set. Let's see if it fits. |
There was a problem hiding this comment.
tACK
congratulations @ndungudedan please add a lightning invoice as a comment on this PR so we can pay to you for this great work
|
Thank you for the guidance and feedback guys. @grunch Here's the invoice: lnbc1pnh09lhpp5tp7vyuxemuucc6ppl4x273s2ury4ye22q2e3j6htxa7jjmr5m36qdqqcqzzgxqyz5vqrzjqwnvuc0u4txn35cafc7w94gxvq5p3cu9dd95f7hlrh0fvs46wpvhd7cwwzegd49gzgqqqqryqqqqthqqpysp57axvkm4aeplu495p7ygrlk9cqyqvezvav0zh59d3a45603l9zvys9qrsgq4hpvffm03e5rqz87anew7um2857sd0uy45kpshm3kexdaacpcnvrsr09e3999t0jav4lrtep7am8xjwrkr2xcwe875rl3qlu4ndlgdqp5xtfd4 |
Amount + fee: 200000 + 380.22 sat |
Resolves #608
The seller receives an image once an order is created. They will also receive the same image when paying the invoice.
This way, they can verify that the invoice originates from the bot.