Changed status of orders after hold invoice expires #617
Conversation
There was a problem hiding this comment.
Hi @Anthonyushie , I've already tested it, have you also tested it locally?
It doesn't work. Here are some clarifications that may be useful:
The hold invoice expires if it is not paid before HOLD_INVOICE_CLTV_DELTA. When an order is in status WAITING-PAYMENT the bot ln node generates a hold invoice ("state": "OPEN") that the seller must pay ("state": "ACCEPTED") but the payment is not executed and sats are not charged until the seller confirms that the fiat has arrived, when it does the bot collects the sats from the seller and the hold invoice changes to "state": "SETTLED". The order changes to status PAID_HOLD_INVOICE and the bot ln node tries to pay the buyer's invoice (it is not a hold invoice). However, if the order is cancelled, or the HOLD_INVOICE_CLTV_DELTA time is reached without the bot node having collected the Sats, then the hold invoice will be cancelled ("state": "CANCELED"). In short: when the order has status PAID_HOLD_INVOICE the invoice will not expire because it has already been paid. It could expire in status ACTIVE, or FIAT_SENT.
| ); | ||
|
|
||
| if (order) { | ||
| OrderEvents.orderUpdated(order); |
There was a problem hiding this comment.
An event should not be published in Nostr with the new order status HOLD_INVOICE_EXPIRED
|
@Catrya |
Implemented logic to change order status when a hold invoice expires, ensuring automatic updates in order management systems post-expiry.
Let me know if there's any issue :)