-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the lightning prefix from the lnInvoice #572
Remove the lightning prefix from the lnInvoice #572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, upon attempting to run it, it fails and throws the following error: Cannot find module './bot_utils'
Yes, you are right, I comitted the missed file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, but it is not necessary to create a new module just for that, but to keep the structure that is already there. You could move it to "util"
I already moved it to the folder util and changed its name to camelcase format names |
Hi @danfercf1 let's wait for @grunch to review and decides |
I think after move the new file to .ts we can merge |
I updated the new file to Typescript |
Hi @danfercf1 thank you for your contribution, before we merge it we need to have the conflict solved, |
I will take a look |
I updated the file validation.ts |
Hey @danfercf1 because we have a buggy PR merged (#557) we need to revert this one, your code is ok I will include in a new version, thanks again |
Removing the lightning prefix from the commands file and the validation
Fixes #542