Skip to content

Commit

Permalink
fix: expiry should default to 3600 (#43)
Browse files Browse the repository at this point in the history
  • Loading branch information
dni authored May 16, 2024
1 parent 12e0205 commit 6ee7118
Showing 1 changed file with 7 additions and 12 deletions.
19 changes: 7 additions & 12 deletions bolt11/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ def validate(self, strict: bool = False) -> None:
raise Bolt11DescriptionException()

def has_expired(self) -> bool:
if self.expiry is None:
return False
return time.time() > self.date + self.expiry

def is_mainnet(self) -> bool:
Expand Down Expand Up @@ -104,20 +102,18 @@ def date_time(self) -> datetime:
return datetime.fromtimestamp(self.date)

@property
def expiry(self) -> Optional[int]:
def expiry(self) -> int:
tag = self.tags.get(TagChar.expire_time)
return tag.data if tag else None
if not tag:
return 3600
return tag.data

@property
def expiry_date(self) -> Optional[datetime]:
if not self.expiry:
return None
def expiry_date(self) -> datetime:
return datetime.fromtimestamp(self.date + self.expiry)

@property
def expiry_time(self) -> Optional[int]:
if not self.expiry:
return None
def expiry_time(self) -> int:
return self.date + self.expiry

@property
Expand Down Expand Up @@ -167,6 +163,7 @@ def data(self) -> dict:
"amount_msat": int(self.amount_msat) if self.amount_msat else 0,
"date": self.date,
"signature": self.signature.hex if self.signature else "",
"expiry": self.expiry,
}
if self.has_payment_hash:
data["payment_hash"] = self.payment_hash
Expand All @@ -178,8 +175,6 @@ def data(self) -> dict:
data["description_hash"] = self.description_hash
if self.metadata:
data["metadata"] = self.metadata
if self.expiry:
data["expiry"] = self.expiry
if self.features:
data["features"] = self.features.readable
if self.fallback:
Expand Down

0 comments on commit 6ee7118

Please sign in to comment.