Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage use of @ in layer names #84

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

ncoghlan
Copy link
Collaborator

  • Updated docs to actively discourage using @ in layers names
  • Rename "explicitly versioned" to "externally versioned", and make it clear that is a separate concept from implicit layer lock versioning
  • Rename fully_versioned_name runtime layer spec field to implementation_name
  • Simplified runtime_name in layer metadata to always refer to the runtime install target
  • Added implementation_name to the published layer metadata
  • Added bound_to_implementation to the published layer metadata
  • Add mechanism to emit FutureWarning for renamed and removed spec fields (which still accepting them)

Continues work on #78

* Updated docs to actively discourage using ``@`` in layers names
* Rename "explicitly versioned" to "externally versioned", and make it
  clear that is a separate concept from implicit layer lock versioning
* Rename `fully_versioned_name` runtime layer spec field to `implementation_name`
* Simplified ``runtime_name`` in layer metadata to always refer to the runtime install target
* Added `implementation_name` to the published layer metadata
* Added `bound_to_implementation` to the published layer metadata
* Add mechanism to emit `FutureWarning` for renamed and removed spec
  fields (which still accepting them)

Continues work on #78
@ncoghlan ncoghlan requested a review from neilmehta24 November 12, 2024 07:30
Copy link

github-actions bot commented Nov 12, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-14 06:59 UTC

github-actions bot added a commit that referenced this pull request Nov 12, 2024
Update expected test output files from automated/expected-output/20241112-073020-9570404 (source PR: #84)
github-actions bot and others added 2 commits November 14, 2024 12:08
Update expected test output files from automated/expected-output/20241112-073020-9570404 (source PR: #84)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ncoghlan ncoghlan merged commit 547c860 into main Nov 14, 2024
11 checks passed
@ncoghlan ncoghlan deleted the discourage-at-symbol-in-layer-names branch November 14, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant